- Dec 15, 2010
-
-
ananta@chromium.org authored
on startup after the machine has been running for a while. For the curious the crash occurs in the tab preview code in Firefox which only executes on Windows 7 and executes even if we disable tab preview. BUG=none TEST=none Review URL: http://codereview.chromium.org/5745008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69218 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5835001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5828002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69217 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=64664 TEST=none Review URL: http://codereview.chromium.org/5859001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69216 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
TBR=yurys BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69215 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5847001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69214 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
errors. TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69213 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69212 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
Generalize tabswitcherview slightly so it doesn't rely on div naming to obtain its styling. BUG=none TEST=none Review URL: http://codereview.chromium.org/5228004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69211 0039d316-1c4b-4281-b951-d872f2087c98
-
tessamac@google.com authored
BUG=62832 TEST=Copied zip to my machine, unzipped, loaded upacked extension. Review URL: http://codereview.chromium.org/5675002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69210 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
Fixes build with latest gcc. Patch from <asharif@chromium.org> BUG=66770 TEST=trybots Review URL: http://codereview.chromium.org/5787005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69209 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Adjusting seccomp through the .gyp file is error-prone and confusing. Instead, because all callers call SeccompSandboxEnabled(), if I want to enable it for some build configuration I can adjust just that function. This change removes all the build-time seccomp configuration and leaves it defaulted off. It should have no change on whether seccomp is enabled. Review URL: http://codereview.chromium.org/5844001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69208 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This makes it pass for all directories except third_party/qcms, which unfortunately needs some careful figuring out of the license. BUG=39240 Review URL: http://codereview.chromium.org/5830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69207 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
Remove the 'restart required' alert when enabling the metrics reporting option, the alert is obsolete. BUG=none TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68919 Review URL: http://codereview.chromium.org/4778002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69206 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=28083 TEST=builds Review URL: http://codereview.chromium.org/5717008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69205 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
Store HostContentSettingsMap separately from the profile in ResourceMessageFilter so we can access it from the IO thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/5785004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69204 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
There was a race condition in ProfileSyncServiceHarness due to its multiple inheritance of ProfileSyncServiceObserver and NotificationObserver, causing several integration tests to fail. This patch contains a fix that involves not inheriting from NotificationObserver, and simply relying on the OnStateChanged() mechanism of ProfileSyncServiceObserver, thereby eliminating the race. It also contains 2 new test cases that further verify passphrase functionality: SetPassphraseAndThenSetupSync and SetPassphraseTwice. BUG=64109 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/5801003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69203 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
BUG= TEST=downloads.py runs fine in Debug Review URL: http://codereview.chromium.org/5730005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69202 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
happen if instant wouldn't load the current url and you continued typing. For example, if the search engine doesn't support the instant API on each key press you would see the page fade out, then snap in. The fix is to make sure instant stays active until destroyed. That way if the preview is no longer valid, but instant is still active the page can remain faded out. This also adds a couple more tests for better coverage. BUG=66720 66539 TEST=see bug Review URL: http://codereview.chromium.org/5701008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69201 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
BUG=66767 TEST=Couldn't repro the problem anymore, but, couldn't repro it more than once even earlier. Review URL: http://codereview.chromium.org/5833001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69200 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager. BUG=58576 TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69088 Review URL: http://codereview.chromium.org/5322001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69199 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/5794004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69198 0039d316-1c4b-4281-b951-d872f2087c98
-
tschmelcher@chromium.org authored
Submitting on behalf of pthatcher@google.com Review URL: http://codereview.chromium.org/5843001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69197 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 14, 2010
-
-
willchan@chromium.org authored
Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5835001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69196 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
This takes care of wrapping a ListItem to give it a delete button, per mocks. Also cleans up some add/remove cruft from browser_options.js BUG=63817 TEST=Startup page rows should have X's to delete them. Review URL: http://codereview.chromium.org/5685003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69193 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/5730003/dmichael@google.com authored
Revert 69187, http://codereview.chromium.org/5730003/. DEPS check failed due to unrecognized Clang includes. BUG=None TEST=None Review URL: http://codereview.chromium.org/5703008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69191 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69190 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/5785005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69189 0039d316-1c4b-4281-b951-d872f2087c98
-
dmichael@google.com authored
PrintNamesAndSizes -Find top-level type definitions. Print their kind (struct, enum, etc), typename, size, and location. FindAffectedInterfaces -Given some typenames, find other types which are affected if that type changes. This is specifically for determining which interfaces are affected by changing a struct or structs. Also add a Makefile to build the plugins and a README describing how to run them. Also add a python script that runs PrintNamesAndSizes with several different targets and generates compile-time checks in to the PPAPI source code to enforce that sizes are consistent, or if they change, we find out quickly. This was broken off from a bigger CL: http://codereview.chromium.org/5340003/ BUG=61004,92983 TEST=None See this CL for an example of what these plugins helped me do: http://codereview.chromium.org/5674004 Review URL: http://codereview.chromium.org/5730003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69187 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Don't release the reference to the ListenSocket before we pass it. This prevents trying to access a deleted object. BUG=59930 TEST=existing Review URL: http://codereview.chromium.org/5786004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69184 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
BUG=28083 TEST=none Review URL: http://codereview.chromium.org/5740005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69183 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Also, always show the apps section. We were only hiding it when there was zero elements when we were in our transitionary phase. To make this look less weird when there are actually zero elements, add the webstore element to the miniview and closed menus. BUG=64737 TEST=In a fresh profile, go to chrome://extensions/ -> developer mode, and click 'update now'. Go to NTP. Should see default apps. Remove all default apps. Apps section should remain. Collapse apps section by clicking heading. Should see webstore item in minimized view. Hide apps section by clicking 'x'. Should see webstore item in closed section menu on bottom of page. Review URL: http://codereview.chromium.org/5804005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69180 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=65973 TEST=none Review URL: http://codereview.chromium.org/5824002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69179 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
multi-DLL build on Windows. TBR=maruel Review URL: http://codereview.chromium.org/5827001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69178 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Have Chrome Frame "support" IE conditional comment tags (of the downlevel-hidden variety) by ignoring them (rather than treating them as comment start/end) when parsing HTML streams. BUG=65627 TEST=chrome_frame_unittests.exe, also syntax like <!--[if IE]><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><![endif]--> will now activate CF. Offtopic: I wonder what happens if I paste HTML into CL comments. Heh. Review URL: http://codereview.chromium.org/5708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69177 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5712009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69176 0039d316-1c4b-4281-b951-d872f2087c98
-
erikwright@chromium.org authored
Implement a ReadyPromptContent that displays a prompt to accept, temporarily decline, or permanently decline ready mode. Implement a RegistryReadyModeState that manages the state (based on user's decision) in the registry. Interfaces to integrate those with the installer. BUG=None TEST=chrome_frame_unittests --gtest_filter='Ready*' Review URL: http://codereview.chromium.org/5747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69175 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/5717003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69174 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/5786005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69172 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/5796007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69171 0039d316-1c4b-4281-b951-d872f2087c98
-
motek@chromium.org authored
They are still errors, but DCHECKs make use of automated testing tools against the debug build virtually impossible. This will be followed-up. BUG=66863 BUG=66864 TEST=none Review URL: http://codereview.chromium.org/5751001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69170 0039d316-1c4b-4281-b951-d872f2087c98
-