- Sep 28, 2010
-
-
willchan@chromium.org authored
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late. BUG=55940 TEST=Manual Review URL: http://codereview.chromium.org/3391028 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3421039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60753 0039d316-1c4b-4281-b951-d872f2087c98
-
cmasone@chromium.org authored
[Chrome OS] Refactor Canonicalize() method into base class to prepare for new Authenticator subclass BUG=chromium-os:4929 TEST=unit tests Review URL: http://codereview.chromium.org/3436031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60752 0039d316-1c4b-4281-b951-d872f2087c98
-
huanr@chromium.org authored
system level in use update. Also remove obsoleted code in this code path. BUG=55969 TEST=repro steps in BUG Review URL: http://codereview.chromium.org/3429029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60751 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
by sending a CONNECT request via a SPDY SYN_STREAM frame to a SPDY proxy, and then reading/writing data to/from SPDY Data frames. BUG=29625 TEST=none Review URL: http://codereview.chromium.org/3432009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60747 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Change from c_str() to data() also did some boundary checks to make there's no memory error. BUG=None TEST=None Review URL: http://codereview.chromium.org/3388024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60746 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=53624 TEST=out/Debug/chrome --enable-tabbed-options, Options > Under the hood > Content Settings > Javascript, you should see "Do not allow any site to run Javascript", instead of 'undefined'. Review URL: http://codereview.chromium.org/3429028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60745 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/3387008tfarina@chromium.org authored
linux: Add support for undo in the omnibox. GtkTextView does not support undo. So borrow the relevant code from GtkSourceView. BUG=18210 TEST=None Patch from sadrul <sadrul@chromium.org> Review URL: http://codereview.chromium.org/3429025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60744 0039d316-1c4b-4281-b951-d872f2087c98
-
chaitanyag@chromium.org authored
Review URL: http://codereview.chromium.org/3442011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60743 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
each file. BUG=none TEST=none Review URL: http://codereview.chromium.org/3431032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60742 0039d316-1c4b-4281-b951-d872f2087c98
-
seh@chromium.org authored
TEST=Open iGoogle, Gmail and the central roster. Start a chat. Check status in all 3 rosters. BUG=chromium-os:1484 Review URL: http://codereview.chromium.org/3455024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60741 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Fix unittest to not use an invalid GURL, as the underlying bookmarks APIs expect callers to not do that (they NOTREACHED()). This URL is more like the real cases the original patch that added this test was trying to handle. BUG=56967 TEST=none TBR=sky Review URL: http://codereview.chromium.org/3439028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60740 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
ChromeOS will create a special Profile for login. Previously, OCSP initialization was done for the "default" ChromeURLRequestContext for each Profile. Since we can have multiple profiles, this causes the initialization (and uninitialization) to happen multiple times, which causes problems for OCSP since we use statics. The solution is to identify the "main" Profile. We create said Profile in BrowserMain. I add an "is_main_" variable to URLRequestContextGetter and URLRequestContext, so that only the "main" URLRequestContext will initialize OCSP. The only change from r59972 is the location that I set_is_main(). I set it when we set the default request context. This is because, by the time I had called set_is_main() in BrowserMain, the ChromeURLRequestContextGetter was already created (it gets created during the CreateProfile() function). So I was too late. BUG=55940 TEST=Manual Review URL: http://codereview.chromium.org/3391028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60739 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/3454022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60735 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Change the default SOCKS version used by gnome settings (and environment variables) to be 5 instead of 4. BUG=56833 TEST=Open Chrome in gnome. Go to change the proxy settings (which will pop open the gnome network settings). Enter as socks proxy server, "localhost:8080". Now load chrome://net-internals/#proxy and verify that it says the proxy server is "socks5://localhost:8080" (and NOT socks4://localhost:8080). Review URL: http://codereview.chromium.org/3413037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60734 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=56967 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60733 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=chromium-os:6543 TEST=make sure chrome:bugreport does not throw exception Review URL: http://codereview.chromium.org/3405037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60732 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
outlived its usefulness. BUG=none TEST=none Review URL: http://codereview.chromium.org/3417025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60731 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 27, 2010
-
-
csilv@chromium.org authored
BUG=52916 TEST=Verify correct page-info icons in GTK. Review URL: http://codereview.chromium.org/3502007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60730 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3394017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60729 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
platforms have different expectations at this level. BUG=none TEST=none Review URL: http://codereview.chromium.org/3418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60728 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60727 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Don't treat ';' as an authority terminator when parsing a potential URL. This was making the omnibox believe that "tl;dr" was a URL with "tl" as a host and ";dr" as a path, confusing it. BUG=56967 TEST=Covered by unittests Review URL: http://codereview.chromium.org/3440032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60726 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=green layout bots TBR=morrita git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60725 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
as well, because gtk cannot be called on a non-UI thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/3384035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60724 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
Somehow it got changed to bad HTTPS in HTTP, but the test was still retrieving the URL from the HTTPS server (which was not running) causing the sub-resource not be found. I looked quickly to see if we could catch calls to GetURL on a non-started server (so we could DCHECK) but there does not seem to be an immediate way to do that. BUG=40932 TEST=Run the test Review URL: http://codereview.chromium.org/3452026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60722 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
This should allow a decoder that can still request the view to allocate frames without being owned by the view itself. This allows for cleaner threading semantics and reduced coupling of classes. The new decoder API keeps the decoder from being aware of the network packet types tightening up the API layering. BUG=52833 TEST=None. This code isn't used yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60703 Review URL: http://codereview.chromium.org/3335012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60721 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=56151 TEST=Verify about:labs refers to 'Tabbed Settings'. Review URL: http://codereview.chromium.org/3436032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60720 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
- the metrics reporting preference is unique, so handle it correctly. - show a 'restart required' alert when changing the metrics reporting setting. - enhance alert overlay to allow only an OK button. - fix a bug in the alert overlay where it was incorrectly loading default strings. BUG=56536 TEST=Verify that the metrics reporting checkbox works properly on Chrome branded builds. Review URL: http://codereview.chromium.org/3419020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60717 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=CID 13105, CID 13106 TEST=dunno Review URL: http://codereview.chromium.org/3389035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60716 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3381027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60715 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
The handlers for messages that originate from render_view, rather than being results of actions started by the plugin itself, can't assume that plugin initialization succeeded. BUG=57085 TEST=Plugins that don't load shouldn't crash. Review URL: http://codereview.chromium.org/3404024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60712 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=none TBR=morrita Review URL: http://codereview.chromium.org/3414022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60711 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3417018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60710 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
request to write a file, as the renderer is most probably compromised. BUG=56725 TEST=none Review URL: http://codereview.chromium.org/3502001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60709 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/3452029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60707 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/3462018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60706 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
Revert "Add in a new FrameConsumer interface, Decode API, and a RectangleUpdateDecoder abstraction." Reverting r60703 due to build break. TBR=willchan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60705 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
platforms have different expectations at this level. BUG=none TEST=none Review URL: http://codereview.chromium.org/3475021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60704 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
This should allow a decoder that can still request the view to allocate frames without being owned by the view itself. This allows for cleaner threading semantics and reduced coupling of classes. The new decoder API keeps the decoder from being aware of the network packet types tightening up the API layering. BUG=52833 TEST=None. This code isn't used yet. Review URL: http://codereview.chromium.org/3335012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60703 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Retaining unknown fields is important for the sync protocol, so it's good to test that it's working. In the future, when we hopefully have a lite runtime with retention abilities, this test will make sure that we haven't broken anything. BUG=56579 TEST=sync_unit_tests http://codereview.chromium.org/3384024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60701 0039d316-1c4b-4281-b951-d872f2087c98
-