- Nov 06, 2024
-
-
Joey Arhar authored
In http://crrev.com/1329409 a call to getAnimations was added to InspectorAnimationAgent::enable, which caused a DumpWithoutCrashing to get frequently hit in ToV8ContextMaybeEmpty. This patch adds a provisional frame check to InspectorAnimationAgent::enable to avoid calling getAnimations in a way that will make this crash. This patch also adds DCHECKs to the DumpWithoutCrashing lines in v8_binding_for_core.cc in order to prevent issues like this from getting through the tests again - it would seem that hitting DumpWithoutCrashing during a web_test is currently not a test failure. (cherry picked from commit 6186fed7) Bug: 40670727 Fixed: 376406320 Change-Id: I12dd4e75d11748aee7d8af8e6c330e1097b112b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980089 Reviewed-by:
Ergün Erdoğmuş <ergunsh@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1378451} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000618 Owners-Override: Srinivas Sista <srinivassista@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6821@{#5} Cr-Branched-From: 32e49867-refs/heads/main@{#1378299}
-
This reverts commit 1e0ee6d1. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5708911974809600 Sample build with failed test: https://ci.chromium.org/b/8732145602164197393 Affected test(s): [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.gesturenav.NavigationTransitionsTest#smokeTest__Gestural](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.gesturenav.NavigationTransitionsTest%23smokeTest__Gestural?q=VHash%3A65f54f06977427ae) [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.gesturenav.NavigationTransitionsTest#testBackNavInRTL__Gestural](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.gesturenav.NavigationTransitionsTest%23testBackNavInRTL__Gestural?q=VHash%3A65f54f06977427ae) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5708911974809600&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5990245&type=BUG Original change's description: > [DNT] Add logs and speculative fix for non-navigatable page on start > > Add logs and sepcualtive fix to track whey the onBackStarted is > triggered even when the page is not navigatable. > > Bug: 376928606 > Change-Id: Ie5976329cb1318a54be5778a39e3df4ecc056652 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5990245 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by:
Theresa Sullivan <twellington@chromium.org> > Commit-Queue: Lijin Shen <lazzzis@google.com> > Cr-Commit-Position: refs/heads/main@{#1378074} > (cherry picked from commit face8ecd) Bug: 376928606 Change-Id: I002f66be94d8e6c7412498edce381a9140cacdfb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992455 Reviewed-by:
Theresa Sullivan <twellington@chromium.org> Commit-Queue: Theresa Sullivan <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1378390} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000447 Reviewed-by:
Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6821@{#4} Cr-Branched-From: 32e49867-refs/heads/main@{#1378299}
-
- Nov 05, 2024
-
-
Chrome Release Bot (LUCI) authored
Change-Id: I0463c475afdc5cb1f84072fe7fafcf4e203e56cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994472 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6821@{#3} Cr-Branched-From: 32e49867-refs/heads/main@{#1378299}
-
Chrome Release Bot (LUCI) authored
Change-Id: I4bb6993a714206271fcdef85afa900a743d06d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992372 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6821@{#2} Cr-Branched-From: 32e49867-refs/heads/main@{#1378299}
-
Chrome Release Bot (LUCI) authored
Change-Id: I1ac3f6f9a4e9f035a7360fe242290a98922e700d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994152 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6821@{#1} Cr-Branched-From: 32e49867-refs/heads/main@{#1378299}
-
Jacob Stanley authored
Screenshots: EEA Consent Skia Gold https://screenshot.googleplex.com/9scp9ybkWAQZBpM ROW Notice Skia Gold https://screenshot.googleplex.com/4f5rBrezSLtAK8i Bug: 377334334 Change-Id: I3a7b9fc68d278b34e2b45de9d5c2652b1ed8c38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989910 Reviewed-by:
Abe Boujane <boujane@google.com> Commit-Queue: Jacob Stanley <jacobstanley@google.com> Cr-Commit-Position: refs/heads/main@{#1378299}
-
Florian Leimgruber authored
crrev.com/c/5993734 changed the GTEST_SKIP() logic. As a result, the compiler now detects that the code is not reachable in certain configurations (as intended). But since warnings are errors, this breaks the builds. This CL fixes this by using #else. Ultimately, the file should probably be excluded from branded builds in the build file. A follow-up CL will attempt to do that. But for now, this CL is a simple fix for the immediate problem. Fixed: 377307126 Change-Id: I8bb96c84faf9ea5d5956b5b5c7d7aa74d5ae1613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993500 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Florian Leimgruber <fleimgruber@google.com> Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Reviewed-by:
Jihad Hanna <jihadghanna@google.com> Cr-Commit-Position: refs/heads/main@{#1378298}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1730807881-8a406b66264d12638c229c1ad3a334735ae21003-b0c639b3.profdata to chrome-mac-arm-main-1730815151-b01e6db58b109229bb7f1c4a97e5e62c26e525d3-3a948f96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I74354126a5e30e070b851eddadd557f892c85f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993878 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378297}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-main-1730785696-cbe944bcbef7471ad8c6cfcf423ca0c7bb8c835c-8fc885dc.profdata to chrome-win32-main-1730797128-4ee74209937e45dc0691eb45956a1fb5a23b83b4-1695afe7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iafc08f9efad5060dc43732003fc94edd98f46af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993162 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378296}
-
chromium-autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1730805247-553c7d508fef822f3780d768015470392595c84b-fb7a41f7.profdata to chrome-android64-main-1730808694-8f630a14e388f05161c49dd73b87c67d8b134830-2950e5c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ife8e457b6cc5e3ef083e25815e2d1911a38650ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991764 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378295}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-main-1730785696-a39c8beee462f64a94b9a7dff9078223467a17f2-8fc885dc.profdata to chrome-win64-main-1730797128-f11ab04d2de89fcd8e7bc983e46cdc3a2e4f37f8-1695afe7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic41bad1c9b9616fc6c8db1de82ec1b4d6754bc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993055 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378294}
-
François Doray authored
Registering an IO Handler can fail (crbug.com/372194029). This CL ensures that all callers handle the failure correctly, instead of ignoring it. Also, it leverages DumpWithoutCrashing and a crash key to collect detailed reports when registration fails. We have evidence that the failure is sometimes caused by 3rd party software, but need more detailed reports to determine whether that occurs frequently. Bug: 372194029 Change-Id: I1f2da01476c4bd7ed85621b687fb1a32fdb5246d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5917190 Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378293}
-
Ankush Singh authored
These metrics are still useful for the batch upload flow from the bookmarks manager. Change-Id: Ia0c5c2b29e16f4d66893b3df0d031979bca96289 Bug: 372006323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5990976 Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Ankush Singh <ankushkush@google.com> Cr-Commit-Position: refs/heads/main@{#1378292}
-
Wolfgang Billenstein authored
This CL is a no-op. Renames AutofillClient::GetAutofillPredictionImprovementsDelegate() to AutofillClient::GetAutofillAiDelegate(). Includes a few minor clean ups around code changed by the renaming. Bug: 375569869 Change-Id: Ic95011205f2fa3598016fbf0d2555c2340d4e78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980210 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1378291}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-main-1730785696-a29d25feb036f80bedb06d06bcdbed0185b49bfa-8fc885dc.profdata to chrome-linux-main-1730807881-0d2102ddc650df602fc62a7c37b90f7dd4c1d16a-b0c639b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iddf97703debe5131982a0fbf34e1b3466fe476b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993874 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378290}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/992ee7708672..7282d547d51b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I72036345e9affee2983999bb95067fdc4ad1f3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993932 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378289}
-
Sylvain Defresne authored
The test TestSecondBlockInvalidatesFirst was incorrectly named, and incorrectly implemented. Fix both. Bug: none Change-Id: I509fac88d0ecd553b4ab417317a865fcd5909f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993731 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378288}
-
Mitsuru Oshima authored
Bug: 374351946 Change-Id: I764f4e45fa88ac0861905467cc8accda8325fe01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988291 Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Ryan Sultanem <rsult@google.com> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378287}
-
Mitsuru Oshima authored
This service isn't necessary in Guest Session Bug: 40257657 Change-Id: Id99b949da8dfb9b83eea9e16977a58eb23a7e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991710 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Ryan Sultanem <rsult@google.com> Cr-Commit-Position: refs/heads/main@{#1378286}
-
Stepan Khapugin authored
This reverts commit b0c639b3. Reason for revert: AccountProfileMapperAccountsInSeparateProfilesTest.RefreshTokenNotification fails on smoke: https://ci.chromium.org/ui/p/chrome/builders/ci/smoke/132891/overview Original change's description: > [iOS] Reload refresh token for added identities > > When the refresh token is updated, the account needs to be reloaded. > This happens when the user enters their password again for an identity > that has a stale refresh token. > > This patch pipes the notification through the list of classes: > - SystemIdentityManager > - AccountProfileManager > - ChromeAccountManagerService > - AuthenticationService > - DeviceAccountsSynchronizer > > The notification is received from iSL with: > crrev.com/i/7782546. > > Bug: 377267745 > Change-Id: Ib90045d3d48a4013baeb4e4990e299a4bf6ed2a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974253 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by:
Arthur Milchior <arthurmilchior@chromium.org> > Reviewed-by:
Marc Treib <treib@chromium.org> > Auto-Submit: Jérôme Lebel <jlebel@chromium.org> > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1378244} Bug: 377267745 Change-Id: I648515cc801be6276f26366dec508501e64fa7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993736 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378285}
-
Dominik Bylica authored
This was tested manually first. I'm adding this test just to ensure this is working forever and ever. Bug: 330383934 Change-Id: If67cfcab0644b49b85f13eb44c38cb6d7f79d2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981092 Reviewed-by:
Andrew Rayskiy <greengrape@google.com> Reviewed-by:
Simon Hangl <simonha@google.com> Commit-Queue: Dominik Bylica <bylica@google.com> Auto-Submit: Dominik Bylica <bylica@google.com> Cr-Commit-Position: refs/heads/main@{#1378284}
-
Kevin Ellis authored
Last step before 100% launch on Finch. Bug: 336294737 Change-Id: I14984e1f874027edff8f30a7ad4c19ef3cab3c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989130 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378283}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7282d547d51b..7c673794123d 2024-11-05 android-test-infra-autosubmit@system.gserviceaccount.com Merge "tp: Add device manufacturer to TraceProcessor" into main 2024-11-05 lalitm@google.com ui: move details panel computation to selection manager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5f55ed2f86c5c92c60128974ee4d99c17f4aabb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993906 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378282}
-
Fredrik Söderquist authored
Rename isValueAllowedInMode to IsValueAllowedInMode and add 'k' prefixes to numCSSValueKeywords and maxCSSValueKeywordLength to better adhere to coding-style. Change-Id: I08d2b8e384155fbc242c6b141a4691ad9d9e5788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988070 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378281}
-
Steinar H. Gunderson authored
Change-Id: Ic3c9021d537d17276142af70c860718aed860e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993754 Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378280}
-
Titouan Rigoudy authored
Bug: 377417379 Change-Id: I3020298f23edcc95fca319eed037b26baf9483ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993452 Owners-Override: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378279}
-
Titouan Rigoudy authored
Bug: 341965228 Change-Id: I79d0bf897f80934473b7039d5d74fe1a2665f01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993851 Owners-Override: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Ali Hijazi <ahijazi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378278}
-
anthie@google.com authored
NO_IFTTT=Fixing a typo in FamilyLinkUserReauthenticationInterstitialState, no functional change. Bug: 374254038 Change-Id: Id75da9967f760e27c586ce0eef53a2ada13082d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966313 Reviewed-by:
James Lee <ljjlee@google.com> Commit-Queue: Anthi Orfanou <anthie@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Duong Dac <ddac@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378277}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/67e6625a278a..368798a17b12 Also rolling transitive DEPS: https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b641ed52301155b70488464e7829efe734020bb..efd1ad5c43b2a8b406d1aa294a3d9d9360034cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/devtools-internal-chromium Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com Change-Id: I8f316b3b3a6f7983ef45e99f6b45aa98f71030d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993870 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378276}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37c0cf910022..bc7f9bfff573 2024-11-05 cbruni@chromium.org Add webpagereplay fetch_config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC chops-source-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:41496458 Tbr: Change-Id: I8a0fe80f51f32392bcdd16b594f5562efee6b755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993063 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378275}
-
Internal Frameworks Autoroller authored
Change-Id: If904262f9f2d9ddf0f82c444505bebefa5f168ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991234 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378274}
-
Colin Blundell authored
These methods are present only for Android WebView. By making them Android-only, we make it more clear that it is not possible on other platforms for the respective dependencies to be created externally to Viz itself. Change-Id: Ia4ac7854245451e8ff98ff46c836445c00468242 Bug: 330865436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991439 Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378273}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/986aab06be43..e08c60961259 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,tju@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: tju@google.com No-Try: true Change-Id: I11b91358354dd880943690026ac5d38d627ca206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993363 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378272}
-
Filipa Senra authored
Bug: 363177541, 376286425, 376288068 Change-Id: Ic1f6ae51bb7ead8b68423d4095e4598737c00fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988071 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Rubin Deliallisi <rubindl@chromium.org> Commit-Queue: Filipa Senra <fsenra@google.com> Cr-Commit-Position: refs/heads/main@{#1378271}
-
chromium-autoroll authored
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1730785696-5ff1249e0f9f796b67ae1841998d717c8c94a9ff-8fc885dc.profdata to chrome-android32-main-1730807881-6964fd21bd6210a581376a26012be7fb9a498aaf-b0c639b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I182c4e9c14cf3cb896b2ccb9d5b3eb498f4c0f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993905 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378270}
-
Wolfgang Billenstein authored
This CL is a no-op: - PS 1: Moves {mock_}autofill_prediction_improvements_delegate.h with tools/git/move_source_file.py. - PS 2: Renames {Mock}AutofillPredictionImprovementsDelegate to {Mock}AutofillAiDelegate. Bug: 375569869 Change-Id: Ie298f9728d0dd838518f7d1c7620dd1bf43670aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5982509 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1378269}
-
Ameur Hosni authored
Bug: 377445611 Change-Id: Ife2f577ed2fac076a9f35b57d3f5236cc88297ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993553 Reviewed-by:
Christian Xu <christianxu@chromium.org> Commit-Queue: Ameur Hosni <ameurhosni@google.com> Cr-Commit-Position: refs/heads/main@{#1378268}
-
Florian Leimgruber authored
Rolls over crrev.com/i/7799548. Fixed: 377322266 Change-Id: I335bbd5820cf36b46446030652d89622039ea926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991441 Reviewed-by:
Jihad Hanna <jihadghanna@google.com> Commit-Queue: Jihad Hanna <jihadghanna@google.com> Auto-Submit: Florian Leimgruber <fleimgruber@google.com> Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Cr-Commit-Position: refs/heads/main@{#1378267}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/66154aac86ff..384547ba31ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,stkhapugin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I83a51cb844d19bc18032e257cc53114308bb9689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992019 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378266}
-
Jihad Hanna authored
Bug: 40944109 Change-Id: Ic8a9b7d475b177e641198ed2ad3752f14b6a44a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979860 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Jihad Hanna <jihadghanna@google.com> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jan Keitel <jkeitel@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378265}
-