- Sep 15, 2009
-
-
nick@chromium.org authored
As before, syncapi is built as a dynamic library, and only on windows. The difference is that it's built from source, rather than being pulled in as a binary. Changes to sync engine code: * Use OS_WIN instead of OS_WINDOWS (requires build_config.h). * Rename platform-specific files to match the chrome convention. This allows them to be excluded by rules that already exist in chrome.gyp. The convention is either a /win/ directory, or an _win.cc at the end of the file. Other valid platforms are _mac, _linux, and _posix Changes to DEPS: * On Windows, pull in pthreads-win32. Changes to chrome.gyp: * Add new library targets for sync, notifier, sync_proto, and syncapi. Review URL: http://codereview.chromium.org/193103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26295 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
Review URL: http://codereview.chromium.org/201127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26294 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
Currently folks who use git to check out the chromium repo cannot run the layout tests on vista because run_webkit_tests.py checks for the existence of platform/chromium-win-vista and git, unlike SVN, will not create an empty directory if one exists upstream. This works around the issue by adding a dummy file to platform/chromium-win-vista so the directory always is there. Review URL: http://codereview.chromium.org/201128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26293 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Make sure that there are no references to tcmalloc code in the Linux build. This is part of an attempt to reland r26264. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26292 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/203076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26291 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Convert the AutocompletePopupPositioner into a BubblePositioner in preparation for using it to position both the Omnibox bubble and InfoBubbles. It now gets the bounds of the location stack, which can be turned into useful coordinates for both items. This should not result in any visible change. BUG=21028 TEST=none Review URL: http://codereview.chromium.org/194110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
BUG=18452 TEST=Try different themes and make sure the extension toolstrips have a nice hover and "pushed" images (by hovering over and then clicking and holding the left mouse button). Review URL: http://codereview.chromium.org/201125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26287 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
I had committed before I got Tony's feedback. This change does some of his suggestions and migrates some info to the wiki. Review URL: http://codereview.chromium.org/195098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26286 0039d316-1c4b-4281-b951-d872f2087c98
-
maf@google.com authored
Add "support_macosx_10_4" option to common.gypi that causes it to change deployment target, and define a new preprocessor symbol on the Mac build. Setting this flag to true is harmless on non Mac builds and has no effect. Make various changes to source files where they modify their behavior in the presence of the new preprocessor symbol to become 10.4 compatible. Review URL: http://codereview.chromium.org/201122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26285 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Moved the function call to the beginning of InitWidgets() to enforce this. BUG=21868 TEST=interactive ui tests still working locally Review URL: http://codereview.chromium.org/205012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26284 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
and all the associated third party packages. Review URL: http://codereview.chromium.org/203077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26283 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/201120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26282 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
Revert "Fix Mac by disabling some UI tests on it." Too many failures. TBR=huanr Review URL: http://codereview.chromium.org/193118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26281 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
The existing code was abusing the WriteInto interface (base/string_util.h). The size passed to WriteInto should be the size of the string plus one for a terminating NUL byte. This bug caused the final newline in the log to be clipped. c_str users (there probably weren't any) would see the final newline which wouldn't be wouldn't be followed by a NUL byte. TEST=not really any BUG=21733 Review URL: http://codereview.chromium.org/194099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26280 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
Not that important anyway, because we don't run automated_ui_tests on Mac yet. TBR=huanr Review URL: http://codereview.chromium.org/193117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26279 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=13156 TEST=Connect view->task manager to first responder's commandDispatch: and give the menu item the tag 40005. Now clicking that menu item should bring up a completely unfunctional task manager window (but it has a localized title and button). Review URL: http://codereview.chromium.org/200094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26278 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
and wstring. TBR=erikkay@chromium.org Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26277 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This reverts commit r26264. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
* Added some AppCacheHost unit tests. * Introduced AppCacheRequestHandler class, which replaces the clunkyApp CacheInterceptor::ExtraInfo struct. This impl is entirely skeletal stubs for now. TEST=appcache_unittest.cc, but really needs more BUG=none Review URL: http://codereview.chromium.org/192043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26275 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Unified the color definitions for the dividers so that extension shelf is using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did. BUG=18452 TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds. Review URL: http://codereview.chromium.org/204026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26274 0039d316-1c4b-4281-b951-d872f2087c98
-
rlp@google.com authored
Review URL: http://codereview.chromium.org/176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26273 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- disable unreliable RestoreTab action - make more command sync, waiting for their completion TEST=none BUG=21547, 21636 Review URL: http://codereview.chromium.org/196096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26272 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Gyp build works on Windows. Mac and linux won't work yet. Fixed some warnings. Switched from dxerr.lib to dxerr9.lib. Implemented a Texture::SetRect case for DXT compressed textures. Fixed division by zero for zero stride vertex buffers. TEST=none BUG=none Review URL: http://codereview.chromium.org/200127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26271 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26270 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
user logout, and during system restart and shutdown. MainMenu.xib changes (because you're not expected to parse nibs yourself): - The quit menu item's action is changed from the AppController object's -quit: method (which no longer exists) to the application object's -terminate: method (the Cocoa standard). - The application and owner object types are changed from NSApplication to CrApplication. - The application menu name is changed from Chromium to ^IDS_SHORT_PRODUCT_NAME. Cocoa doesn't use this anyway, it gets replaced at runtime with the localized value of CFBundleName, but we shouldn't have branding-specific strings in our nibs. BUG=18078 TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch. You should NOT see the "Google Chrome didn't shut down correctly" info bar. Review URL: http://codereview.chromium.org/201121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26269 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/195095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26268 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/206018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26267 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@chromium.org authored
* expand/collapse to chrome-extension://crashme no longer crashes * expand/collapse to a relative URL now works BUG=20412,21905 TEST=browser_tests ExtensionApi.Toolstrip (note that the test doesn't actually exercise these changes due to 21905) Review URL: http://codereview.chromium.org/195093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26266 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Flash misbehaves if you load it from a path containing "netscape", so we try to avoid and warn the user if necessary. BUG=20758,21900 Review URL: http://codereview.chromium.org/206009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26265 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
Landing of Anton Muhin's patch (antonm@google.com) BUG=none TEST=none Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/193115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26261 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/193032sky@chromium.org authored
First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Review URL: http://codereview.chromium.org/194118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26255 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=dglazkov TEST=none BUG=none Review URL: http://codereview.chromium.org/195092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26254 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
1) Tell the AppCacheService which request context to use when fetching resources for updates. Done for both chrome and test_shell. The service does not yet take a reference to that context, because the extra reference apparently gives some tests grief. 2) Added methods to generate new storage ids for different object types on the IO thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/195077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26253 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
The "make default" button Auto size to always fit the text. Be a small style control, look better (changes font). General fix up so the window resizes. TableView Turn off column select Turn off multiple selection (code doesn't support it on delete). Update the xib for the class name change that happened as part of the prior commit. BUG=21892 TEST=window resize correctly, make default button fits it's text for all languages. Review URL: http://codereview.chromium.org/206016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26252 0039d316-1c4b-4281-b951-d872f2087c98
-