- Nov 03, 2009
-
-
mirandac@chromium.org authored
BUG= http://crbug.com/19282 TEST= Use report bug dialog on Mac OSX. Review URL: http://codereview.chromium.org/340039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
document_idle." Original code review: http://codereview.chromium.org/339064 BUG=26126 TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30796 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30787 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it". Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first. BUG=26126 TEST=Manual. Extensions with content scripts should work. Review URL: http://codereview.chromium.org/339064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30784 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/276029/showmad@chromium.org authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 02, 2009
-
-
estade@chromium.org authored
Handle GTK enter and leave notification events and pass them to WebKit as mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98
-
yaar@chromium.org authored
(in preparation for upstreaming the api) Review URL: http://codereview.chromium.org/340049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30764 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
See http://codereview.chromium.org/340045 for the original code. This includes a newer version of GTM that solves the problem with nib loading on 10.6. TEST=http://codereview.chromium.org/340045 BUG=none Review URL: http://codereview.chromium.org/343082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30743 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
Review URL: http://codereview.chromium.org/339079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30738 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726 TBR=estade Review URL: http://codereview.chromium.org/343080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show Review URL: http://codereview.chromium.org/354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=9295,8077 TEST=trybots Review URL: http://codereview.chromium.org/340052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30714 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
10.6 loads xibs differently, breaking GTMIBArray TBR=mark@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30702 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
- These two pages should now auto size vertically the labels. - The label should be top aligned with controls in the group when the group is taller. - The content should be vertically centered when the label is taller. - All the textfields should always be tall enough to show content. - Radios/checkbox should word wrap to show all their text. - The spacing between groups is a little more even - DEPS roll to pick up newer GTM with GTMIBArray. - A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc. Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment). Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up). TEST=see cl description for what should be working now. BUG=20538 Review URL: http://codereview.chromium.org/340045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30696 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Add the ability for objects which derive from RefCountedThreadSafe to specify a destructor trait. This allows browser objects to specify which thread they're terminated on. The benefit is we avoid the need to do manual ref counting when an object posts tasks to itself on different threads, if an object must be destructed on a specific thread. This patch adds initial support and only shows one example with ResourceMessageFilter. I will do the rest in a follow-up patch to keep things small. BUG=25354 TEST=added unit tests Review URL: http://codereview.chromium.org/338065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30688 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable. The shell tries to treat it as a command expansion. Use ${BUILT_PRODUCTS_DIR} directly. BUG=none TEST=Nico Review URL: http://codereview.chromium.org/353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30686 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 30, 2009
-
-
johnnyg@chromium.org authored
Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module. BUG=none TEST=none Review URL: http://codereview.chromium.org/343066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
In theory this should result in a slightly faster app startup. I will do a follow up change to merge it on Windows and get rid of the code related to the extra file. BUG=24035 Review URL: http://codereview.chromium.org/344038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
of HtmlDialogView. Added TODO to fix inaccurate font height metric for OS X font class (and maybe width). Added the BrowserCommandExecutor protocol so that not just a BrowserWindowController can be the window controller for a ChromeEventProcessingWindow. Added unittests. Also tested manually with the bookmark sync setup wizard dialog. BUG=23073 TEST=added unittests, trybot, and manual testing Review URL: http://codereview.chromium.org/344008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
Added initial interface hooks betweek WebKit code and renderer-side worker code. The proper messages are generated to fire off a shared worker, but they are currently ignored by the browser process. BUG=26233 TEST=none (will enable layout tests when basic functionality available) Review URL: http://codereview.chromium.org/340036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30599 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* It simply says it's not supported as ChromeOS wont launch external program. Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary. BUG=23853 TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog. Review URL: http://codereview.chromium.org/342040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30593 0039d316-1c4b-4281-b951-d872f2087c98
-
brg@chromium.com authored
Implement the Extension History API, v 0.1.The first version is a weak wrapper around the HistoryServices object in Chrome.BUG=22952TEST=browser_tests.exe --gtest_filer=ExtensionApiTest.History Review URL: http://codereview.chromium.org/313001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30561 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Connect the various pieces for notifications... hook up NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView. BUG=none TEST=none Review URL: http://codereview.chromium.org/342043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30557 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now. BUG=23526 TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload. Review URL: http://codereview.chromium.org/327009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 29, 2009
-
-
http://codereview.chromium.org/337010/show/mrossetti@chromium.org authored
BUG=25099 TEST=See 337010. Review URL: http://codereview.chromium.org/343042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30523 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
This change adds 2 new menu items to the option menu. There is pref migration code to make tips and sync visible by default. BUG=24319 TEST=Hide and show the different sections and reload to make sure it is persisted across instances of NTP. Review URL: http://codereview.chromium.org/337011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30495 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
time_posix.cc has the actual code and compiles on Linux already. Including both files causes linker errors for the shared build. BUG=none TEST=compiles on trybots Review URL: http://codereview.chromium.org/341035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30492 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
BUG= none TEST= bug reporting should work the same on Windows. Review URL: http://codereview.chromium.org/339051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30486 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Factor search vs. navigate classification into its own file to make it more broadly usable. Patch by Thiago Farina (see http://codereview.chromium.org/328031 ), r=me. BUG=21317 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30473 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
Adds UI components for desktop notifications, including balloon view classes to display toasts on the screen, and manager for controlling the layout of the balloons. BUG=none TEST=none yet (part of larger patch) Review URL: http://codereview.chromium.org/338051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30471 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
On the mac, there can be no windows, but the application is sitll open. This confused "Restore the pages that were open last" so that it would restore when opening a new window. BUG=13341 TEST=Open chromium. Set On Startup to "Restore the pages that were open last". Open a few tabs. Close the window (but not chromium). Click the dock icon. The tabs shouldn't be restored. But if you quit chrome and start again, things should reopen. Review URL: http://codereview.chromium.org/340023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30463 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
privacy blacklists with extensions. - change I/O routines interface to be more clear - distinguish between transient and permanent blacklists - remove obsolete code (pbl_tool and blacklist error dialog) BlacklistManager will be responsible for recompiling the persistent blacklists. Errors will be reported via infobars. TEST=Covered by unit_tests. BUG=21541 Review URL: http://codereview.chromium.org/337025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30449 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
Run with --enable-web-sockets enables WebSocket features. BUG=12497 TEST=none Review URL: http://codereview.chromium.org/292044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30440 0039d316-1c4b-4281-b951-d872f2087c98
-
- Oct 28, 2009
-
-
sky@chromium.org authored
views/gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/338067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30403 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* Added OnMouseXXXTab methods to BrowserExtender to handle on tabs. * Changed tab to call above methods. * Added GetSelectedTab to TabStrip Minor changes along with the major changes above * Removed unnecessary file entries in chrome.gyp * Fixed a few method's const. * Removed unnecessary class declarations and includes. Know issue: keyboard focus is not working. In 2nd step, I'm going to eliminate popup and use whatever that FindBar is using to show compact location bar. I'll fix the issue above after this migration. (if it still persists) BUG=None Test=None Review URL: http://codereview.chromium.org/341008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30386 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
- only include cflags/linkflags and other compiler settings that are target-specific when building for 'target' - make build tools (protoc) compile for 'host', and change the dependencies on them to reflect that. Review URL: http://codereview.chromium.org/265031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30381 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
Add initial implementation of AutoFill++. This implementation is hidden behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/339030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
-