BUG=http://crbug.com/22882
TEST=Type something into the omnibox.  Option-return should open it in a new foreground tab.
TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url.
TEST=Option-leftclick on a link in a webpage should still prompt you to "save as."
Review URL: http://codereview.chromium.org/218032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27127 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
Review URL: http://codereview.chromium.org/231022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27115 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view.

BUG=None
TEST=Run all tests. Make sure focus is stored/restored properly in Chrome.

Review URL: http://codereview.chromium.org/214029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/22558
TEST=Go to https://www.twitter.com/.  See the cert mismatch warning.  Check that "https://" in the omnibox is red with a strikethrough.
Review URL: http://codereview.chromium.org/215038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27064 0039d316-1c4b-4281-b951-d872f2087c98

Obvious result of Rohit's addition of paste-and-go and my refactor to
add AutocompleteTextFieldObserver.  Bonus prize of unit tests for
cocoa/ part of Rohit's change.

Review URL: http://codereview.chromium.org/207047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26993 0039d316-1c4b-4281-b951-d872f2087c98

This reduces the number of forwarding/delegate shenanigans we have to
go through.

Review URL: http://codereview.chromium.org/211030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26710 0039d316-1c4b-4281-b951-d872f2087c98

We override -paste: to do Chrome-specific stuff.  This circumvents
certain Cocoa-standard setup which happens when user's edit text
views, and elsewhere we depend on that setup being right.  This
changes our code to participate in that setup process.

http://crbug.com/21301
TEST=Copy "raising arizona" to the clipboard.  Put focus in the NTP
(Omnibox field does not have focus ring).  Click in Omnibox field and
paste.  Should now see autocomplete popup.

Review URL: http://codereview.chromium.org/213029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10937
BUG=http://crbug.com/13021
TEST=Omnibox context menu should contain paste and go/search.
Review URL: http://codereview.chromium.org/192008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26603 0039d316-1c4b-4281-b951-d872f2087c98

empty protocol definitions for compatibility.

BUG=20925
TEST=build
Review URL: http://codereview.chromium.org/209004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26477 0039d316-1c4b-4281-b951-d872f2087c98

error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing
Review URL: http://codereview.chromium.org/204028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26304 0039d316-1c4b-4281-b951-d872f2087c98

Convert the AutocompletePopupPositioner into a BubblePositioner in preparation for using it to position both the Omnibox bubble and InfoBubbles.  It now gets the bounds of the location stack, which can be turned into useful coordinates for both items.

This should not result in any visible change.

BUG=21028
TEST=none
Review URL: http://codereview.chromium.org/194110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26288 0039d316-1c4b-4281-b951-d872f2087c98

It also contains clean-ups and implementation of different minor focus related things.

BUG=None
TEST=Open several tabs. Focus the location bar for some tabs, the page for others. Make sure that when switching between tabs the focus is restored to the last focused place (location bar or page) for each tab.
     Also test that deactivating/reactivating the browser window still restores focus properly.

Review URL: http://codereview.chromium.org/194041


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26153 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes issue 21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.

BUG=21362: The original text and selection can't be reverted correctly when pressing escape key in omnibox if currently selected line is not the default match.
TEST=Input something in omnibox and make sure inline autocomplete is triggered, then press down to select another line, then press escape to revert to the default match and see of the original text and selection was reverted correctly.

Review URL: http://codereview.chromium.org/194056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25968 0039d316-1c4b-4281-b951-d872f2087c98

Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168.

BUG=4360
BUG=21228
BUG=18792
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/173343

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25442 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/20455
TEST=Enter "this" into address bar.  Hold Control, should see
"www.this.com" as first item.  Release, and it should go back to
"this" immediately.

Review URL: http://codereview.chromium.org/182021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24939 0039d316-1c4b-4281-b951-d872f2087c98

There are some crashers which show up as an objc_msgSend when posting
a notification.  So I went around reviewing our observers looking for
places where it's possible that we weren't unregistering correctly.
These may have already been correct, but this change would seem to
make unregistration more reliable.

Review URL: http://codereview.chromium.org/174480

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24938 0039d316-1c4b-4281-b951-d872f2087c98

Option-return inserted a literal newline, did not want.  Also fixed
Option-tab to not insert literal tab.

http://crbug.com/17914
TEST=Type text, option-tab should not insert literal tab,
option-return should not insert newline.  Both should do nothing.

Review URL: http://codereview.chromium.org/181024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24936 0039d316-1c4b-4281-b951-d872f2087c98

When the user hits shift-delete (that's forward delete),
attempt to delete the item highlighted from the list.  This only seems
to work for history items.

http://crbug.com/20281
TEST=No idea.  I've managed to delete an item, but most items seem
immune to deletion, this code is calling the right place, but the
match itself checks !deletable.  Sometimes I have luck going to a
site, then typing part of the URL and using shift-del on it.

Review URL: http://codereview.chromium.org/176022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24819 0039d316-1c4b-4281-b951-d872f2087c98

When the user hits backspace with the caret on the LHS in a keyword
search, should exit keyword search.

[Apple keyboards may label what I'm calling "backspace" as "delete".
The wide key above |\ key.]

http://crbug.com/20286
TEST=Type www.google.com, then tab to enter keyword search.  Type some
text.  Select-all and hit backspace, should stay in keyword mode.
Type some text, backspace should work as normal.  Type some text,
position caret at LHS, backspace should take you out of keyword mode.

Review URL: http://codereview.chromium.org/180009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24767 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/20284
TEST=Type "test text".  You should see "Type to search" hint.  TAB
should take you into the content view.  Unfortunately, there are other
unrelated bugs around the tab sequencing, so this only works with NTP
on a new window.  Hit TAB twice and you should start tabbing between
thumbnails.

Review URL: http://codereview.chromium.org/180010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24741 0039d316-1c4b-4281-b951-d872f2087c98

rather than simply growing its width by 2*height.

BUG=None
TEST=The autocomplete popup should continue to appear in the same location.
Review URL: http://codereview.chromium.org/173439

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10944
BUG=http://crbug.com/10943
BUG=http://crbug.com/12285

TEST=With empty field, should see "Type to search" in light text on
the RHS of the omnibox.  Type "google" and should see "Press [Tab] to
search Google" in light text on the RHS.  Hit TAB, should see a
rounded [Search Google:] item on the left and the cursor is now right
of that.  Popup should show "Keyword:" in some entries.

Patch by shess@chromium.org.
Review URL: http://codereview.chromium.org/173194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23964 0039d316-1c4b-4281-b951-d872f2087c98

This issue is caused by AutocompleteEditViewMac::SetText() that updates the value of an AutocompleteEditField instance while an input method is composing text. Same as Windows, NSTextView finishes an ongoing composition when we update the value of an AutocompleteEditField object.
To fix this issue, we check whether or not NSTextView has marked text and exit if it has.

BUG=19421 "Korean IME does not work in the omnibox"
TEST=Select Korean 2-set keyboard, type 'g', 'k', 's', 'r', 'm', 'f' keys, and verify we can see two Korean syllables.

+rohitrao for reviewers since shess is out for the week
Review URL: http://codereview.chromium.org/171103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23702 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/172082

Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition
cracking.

Hook this up to BookmarkBarController so that clicks to bookmark items use the
oracle function to determine where the bookmark should be opened.

BUG=17301
TEST=Cmd+Click etc on bookmark items should work. See bug and unit test
attached.

http://codereview.chromium.org/174021

Convert users of the "get last active browser, get selected tab contents, open
url" pattern to just call OpenURL on Browser directly.

Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can
be called with a provided profile.

BUG=none
TEST=Try opening links from the bookmark/history menus on mac, with and without
an existing window open, with an active incognito window, etc. The links should
all open in the last active non-incognito window, or create a new non-incognito
window if none is open.

Review URL: http://codereview.chromium.org/173044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23693 0039d316-1c4b-4281-b951-d872f2087c98

* Add cocoa_utils.{h,mm} and a unit test for the one method it contains:
  event_utils::DispositionFromEventFlags().
* Add modifier key support to the history menu, bookmark menu, infobars,
  bookmark bar, and Omnibox.

BUG=17912,17301
TEST=When using the aforementioned UI elements, Cmd should open in new
foreground tab, Cmd+Shift should open in new background tab, and Shift should
open in a new window.

Patch by Robert Sesek.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23636 0039d316-1c4b-4281-b951-d872f2087c98

Use en-dash instead of em-dash to separate match and description.

Popup font a little smaller than field font.

Make cell taller, and no gap between cells.

Use BaseFont from ResourceBundle instead of field's default font (this
is what Windows uses, I think).

http://crbug.com/19184

Review URL: http://codereview.chromium.org/164418

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23273 0039d316-1c4b-4281-b951-d872f2087c98

The popups now interact with the edit via AutocompleteEditView rather than the platform-specific types.

Note this also removes the old omnibox popup code. It hasn't been active for some time.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160378

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22168 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/17013
TEST=Browse to www.google.com.  Click in the field.  Up-arrow should
go to beginning of line, down-arrow to end.

Review URL: http://codereview.chromium.org/155871

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21310 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/10934
TEST=Type 'something', and press Control.  Autocomplete should show www.something.com at the top.  If that's what you'd get anyhow, try a different word.  Control-enter should take you there.

Review URL: http://codereview.chromium.org/159105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21192 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/11817
TEST=Copy an URL somewhere and break it apart with newlines at random places.  Copy/paste it into omnibox and the newlines should be gone.  Try this one:

http://dev.chro
mium.org/develo
pers/how-tos/ge
t-the-code

Review URL: http://codereview.chromium.org/159018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21125 0039d316-1c4b-4281-b951-d872f2087c98

LocationBarCell -> AutocompleteTextFieldCell.
LocationBarFieldEditor -> AutocompleteTextFieldEditor.
AutocompleteTextField added as placeholder for future work (hints and
keyword search).

Review URL: http://codereview.chromium.org/149717

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98

Reapplies http://codereview.chromium.org/149492 .  That version was
accidentally calling this code as part of the class implementation,
which caused the code to receive the "done editing" notification,
which caused the code to drop the popup...

This version stops using FocusLocation() internally, instead messaging
field_ directly.

http://crbug.com/12246
TEST=Type some stuff in address bar.  Popup should popup with suggestions.  With cursor still in bar, Command-l should select all.

Review URL: http://codereview.chromium.org/155537

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20769 0039d316-1c4b-4281-b951-d872f2087c98

Backing out r20493 (http://codereview.chromium.org/149492), as it inadvertently killed the Omnibox suggestion list.

BUG=http://crbug.com/16714
TEST=Type in the omnibox; you should get a suggestion list.

Review URL: http://codereview.chromium.org/149622

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20642 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/15811
TEST=Browse to www.google.com.  Focus is in document.  Click Go.  No more crash.

Review URL: http://codereview.chromium.org/149487

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20495 0039d316-1c4b-4281-b951-d872f2087c98

Previous version was perhaps too optimal.  This should be reasonable
for now since it only happens at the pace the user can enter input.

http://crbug.com/14628
TEST=Browse to www.google.com.  Copy/paste the entire URL.  Should be styled.

Review URL: http://codereview.chromium.org/149489

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20494 0039d316-1c4b-4281-b951-d872f2087c98

I went auditing around, and AFAICT all remaining callers should be
fine with selecting everything.

http://crbug.com/12246
TEST=Type some stuff in address bar.  With cursor in bar, Command-l should select all.

Review URL: http://codereview.chromium.org/149492

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20493 0039d316-1c4b-4281-b951-d872f2087c98

During the course of this, I gave in and implemented
EmphasizeURLComponents() for consistency with Windows and GTK.  Since
modifying the text changes the selection, added
SetTextAndSelectedRange() to make operations doing both easier to get
right.  Renamed UpdateAndStyleText() to SetText() for consistency.

http://crbug.com/14122
TEST=See bug.

Review URL: http://codereview.chromium.org/125201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18621 0039d316-1c4b-4281-b951-d872f2087c98

visibly differ from the model's text.

In most cases, this doesn't come up, because focus is usually not in
the field (so there wouldn't be local changes), but when opening NTP
you can type between when the tab opens in the browser and when the
renderer finishes loading it.  In that case, the model and toolbar
both have "" as the url text, so this case is hit.

http://crbug.com/13109
TEST=Browse to www.google.com.  Command-t for new tab and type http as fast as you can.  Before this fix, you sometimes got "tp" or something of the sort.

Review URL: http://codereview.chromium.org/119125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17662 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/11920
TEST=Browser to www.google.com, focus is in search field, bring up new tab, click back to first tab, focus should be in search field.
TEST=Select messages in gmail, focus should NOT go to autocomplete field (omnibox, url bar).

Review URL: http://codereview.chromium.org/113751

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16823 0039d316-1c4b-4281-b951-d872f2087c98