- Nov 18, 2010
-
-
antonm@chromium.org authored
Review URL: http://codereview.chromium.org/5091004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66633 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
- Move Linux's CanvasSkia::DrawStringInt into DrawStringWithHalo and added code to support text halo and change DrawStringInt to use it; - Make views::TextButton support text halo; - Use the text halo for chromeos::StatusButton; BUG=chromium-os:8657 TEST=Verify 1px black border is added to ChromeOS status buttons. Review URL: http://codereview.chromium.org/5071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66632 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Previously, the logic was: 1.) Clear plugin background 2.) If the plugin didn't update, return early 3.) Paint plugin 4.) "Swap buffers" But the "Swap buffers" step only unbound and rebound an FBO object If the plugin didn't change, its backing store would contain transparent black, and if the graphics driver decided to flush the FBO for another reason than a "swap buffers" call, the blackness would show up in the browser. This CL swaps steps 1 and 2, so even if the FBO is flushed for some unrelated reason, we display something valid. BUG=60341 TEST=Open the file attached to the bug. Resize the window for a few minutes, put the computer to sleep and back on, resize window for a few more minutes. The plugin area (the 191x60px rect in the middle) shouldn't become black. YouTube should still work. CPU usage shouldn't be worse than it was before for the browser, plugin, and renderer processes. Review URL: http://codereview.chromium.org/5220002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66631 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
When I fixed the code not to be re-entrant (since that caused crashes) in r61880, I created a window when the pending create callback was posted to the MessageLoop to be run on the next iteration. In this window before it actually gets invoked, if the pending stream creation got cancelled, then the callback wasn't cancelled, so we would execute a callback on a cancelled stream creation, which can cause crashes. The fix is to keep track of the pending callbacks. Cancellation of pending stream creations check this pending callback map first. BUG=63532 TEST=See bug thread for repro steps. New unit test added as well. Review URL: http://codereview.chromium.org/5174005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66630 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=25039 TEST=none Review URL: http://codereview.chromium.org/5229001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66629 0039d316-1c4b-4281-b951-d872f2087c98
-
rdsmith@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/5166002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66628 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5125003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66627 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
DnsCertProvenanceChecker is introduced to abstract away the action of uploading reports. It's implemented by ChromeDnsCertProvenanceChecker which lives in a scoped_ptr off of a URLRequestContext. It's only active on the main context (i.e. not in incognito mode). This might change in the future, but it's a nice, conservative choice for the moment. The DnsCertProvenanceChecker is plumbed all the way to SSLClientSocket (via HttpCache) where it replaces the DnsRRResolver. Above SSLClientSocket, it's plumbed in addition to the DnsRRResolver because the later will end up going into SSLHostInfo in the future. At the moment, ChromeDnsCertProvenanceCheckerContext is just a skeleton to avoid putting too much real code in a plumbing job. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66623 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
Also adds a little more infrastructure to assist in openssl error handling. BUG=None TEST=base_unittests RSA* and Sign* Review URL: http://codereview.chromium.org/5105003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66622 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Nested tasks are generally allowed for context menus (e.g. in MenuController::Run, NativeMenuDOMUI::RunMenuAt). Do the same here. This fixes a X-freeze caused by context menus when touchui=1 with the X message-pump. BUG=none TEST=manual, context menus in web-pages should work and not freeze X. Review URL: http://codereview.chromium.org/5206002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66621 0039d316-1c4b-4281-b951-d872f2087c98
-
inferno@chromium.org authored
BUG=63529 Review URL: http://codereview.chromium.org/5173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66620 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@google.com authored
when passed a net::ERR_NETWORK_ACCESS_DENIED error. This results in a error code being output by the security/block-test-no-port.html layout test on OSX that is consistent with other platforms. The test is also temporarily disabled on OSX until the expected results are updated. BUG=61655 TEST=security/block-test-no-port.html (Currently disabled) Review URL: http://codereview.chromium.org/5012005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66619 0039d316-1c4b-4281-b951-d872f2087c98
-
antonm@chromium.org authored
TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/5185002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66618 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@chromium.org authored
BUG=chromium-os:9248 TEST=Manually. Review URL: http://codereview.chromium.org/5173001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66617 0039d316-1c4b-4281-b951-d872f2087c98
-
erik.corry@gmail.com authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/5210003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66616 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=58235 TEST=none Review URL: http://codereview.chromium.org/4832002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66615 0039d316-1c4b-4281-b951-d872f2087c98
-
avayvod@chromium.org authored
BUG=chromium-os:9342 TEST=Check that tap-to-click is on on login screen and for users with default setting. Review URL: http://codereview.chromium.org/5146003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66612 0039d316-1c4b-4281-b951-d872f2087c98
-
glotov@google.com authored
BUG=chromium-os:8350 TEST=none Review URL: http://codereview.chromium.org/5160003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66611 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66607 0039d316-1c4b-4281-b951-d872f2087c98
-
leandrogracia@chromium.org authored
language in case that no language attribute is provided. For this, the l10n_util::GetApplicationLocale was used from the IO thread. However this is not valid since that function requires file access. After considering different options this patch now uses the first of the accepted languages, defaulting to "en-US" in case that this list is empty. BUG=53598 TEST=SpeechRecognitionRequestTest Review URL: http://codereview.chromium.org/4896001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66605 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
SyncerThreadWithSyncerTest.AuthInvalid) TBR=timurrrr BUG=63590 Review URL: http://codereview.chromium.org/5222001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66604 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
to mock menu item strings. BUG=63460 TEST=LayoutTest/editing/spelling/context-menu-suggestions.html Review URL: http://codereview.chromium.org/5120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66603 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=63590 TBR=timurrrr Review URL: http://codereview.chromium.org/5156005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66602 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
Add for each policy the version number of Chrome when is was introduced. Update platform-based policy filtering to use the new template format (no new logic introduced.) Update the HTML documentation writer to use the new version numbers. BUG=62500 TEST=PolicyTemplateGeneratorUnittest.testPolicyFiltering,DocWriterUnittest.testAddPolicyDetails,DocWriterUnittest.testAddPolicySection Review URL: http://codereview.chromium.org/4704006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66601 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TBR=aa BUG=63589 TEST=browser_tests Review URL: http://codereview.chromium.org/5221001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66600 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=None TBR=antonm@chromium.org Review URL: http://codereview.chromium.org/5220001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66599 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
These were probably copied to c/b/renderer_host a while ago, and nobody removed them from their old location. BUG=none TEST=none Review URL: http://codereview.chromium.org/5169001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66598 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
It is possible both of them have problems, but the logs I captured earlier are for OnSubmitEvent. TBR=tonyg BUG=62940 TEST=interactive_ui_tests Review URL: http://codereview.chromium.org/5219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66597 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=None TBR=antonm@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66595 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Included logic for connection recovery - if we fail or timeout (30 sec) while trying to reconnect the process of reconnecting will be repeated 10 times before we throw an error. BUG=chromium-os:9304, chromium-os:9333 TEST=none Review URL: http://codereview.chromium.org/5147004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66593 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=None TBR=antonm@chromium.org Review URL: http://codereview.chromium.org/5109007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66592 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
Required for debugging test failures seen only on the chrome buildbots. BUG=none TEST=sync_integration_tests Review URL: http://codereview.chromium.org/5139004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66589 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66587 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/5121006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66583 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/4139008aa@chromium.org authored
approach to creating version numbers. The old one had troubles with timezones. This one is simpler and better. BUG=49233 TEST=Covered by unit tests Review URL: http://codereview.chromium.org/4471001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66582 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Same icons, except the corner transparencies are cleaned up. BUG=51105, 27941 TEST=none Review URL: http://codereview.chromium.org/5214001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66580 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
(in particular defined by macros) to wide string constants. Convert existing locally-defined stringizing to use the shared macros. Unit tests for the shared macros. This also fixes a minor bug in ceee_module_util.cc where I accidentally quoted a string constant I only meant to convert to wide (this caused no bug, but was unintended, so the change in semantics in that file in the current change is intentional). BUG=none TEST=automated tests Review URL: http://codereview.chromium.org/5103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66579 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Remove a definition in a weird spot since it's only used on Solaris, which nobody is actively porting to right now. BUG=none TEST=none Review URL: http://codereview.chromium.org/5202001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66578 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5044001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66576 0039d316-1c4b-4281-b951-d872f2087c98
-