Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now.

BUG=23526
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload.

Review URL: http://codereview.chromium.org/327009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98

Based on the rest of the codebase, I think we're supposed to #include chromium_strings rather than google_chrome_strings, although I doubt it would matter.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30546 0039d316-1c4b-4281-b951-d872f2087c98

This is an experiment to see the current status of
the test.

BUG=13921
TEST=warm perf load test is greenish

Review URL: http://codereview.chromium.org/342045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30545 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19980
TEST=See the steps in the bug description. 

Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008

Review URL: http://codereview.chromium.org/339075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19852
TEST=See repro steps of the bug 

Patch by Bruno Calvignac <BrunoCalvignac@gmail.com>
Original CL http://codereview.chromium.org/282004

Review URL: http://codereview.chromium.org/342046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30540 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30539 0039d316-1c4b-4281-b951-d872f2087c98

-. Rebaseline deletionUI-single-instance pixel result due to upstream change: http://trac.webkit.org/changeset/49641 
-. Update bug number in test expectations

R=japhet
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25275
TEST=play src\media\test\data\48_aac_infinite_loop.m4a and it should not hang.

Review URL: http://codereview.chromium.org/343046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30537 0039d316-1c4b-4281-b951-d872f2087c98

Picks up making vs2008 projects by default, and adding a new variable into make/scons builds.

BUG=22307
TEST=gyp try bots were green.

Review URL: http://codereview.chromium.org/348016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30536 0039d316-1c4b-4281-b951-d872f2087c98

Add more comprehensive whitelist/blacklist logic so that we can easily switch defaults.

BUG=24918,26110
TEST=Install plugin, follow a link to a PDF; you should not get a page with nothing but a crash notification for the plugin.

Review URL: http://codereview.chromium.org/342029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23865

Review URL: http://codereview.chromium.org/341025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/342044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30533 0039d316-1c4b-4281-b951-d872f2087c98

Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while.

BUG=24632,24889
TEST=Tests not super flaky

Review URL: http://codereview.chromium.org/345024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30532 0039d316-1c4b-4281-b951-d872f2087c98

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.

Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16371
TEST=Check the crash logs to see if this CHECK() supplants the CHECK() failure in AsyncResourceHandler::OnWillRead()
Review URL: http://codereview.chromium.org/347012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30530 0039d316-1c4b-4281-b951-d872f2087c98

We modify test_shell --check-sys-deps to allow Win 7, add a "chromium-win-7"
port to platform_utils, a "WIN-7" port to test_expectations, and create
an empty shell directory under webkit/data/layout_tests to make the
regression scripts happy.

The actual new baselines will follow in a separate CL.

  R=ojan@chromium.org
  TEST=none
  BUG=none

Review URL: http://codereview.chromium.org/342033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30528 0039d316-1c4b-4281-b951-d872f2087c98

1) Always intialize the css cache.  Previously we were only
initializing if not in incognito mode.  If the first NTP was an
incognito page, it wouldn't be styled.

2) Small optimization in generating the HTML to avoid calling
ReplaceFirstSubstringAfterOffset which would need to move the
bytes after the placeholder.

3) Only generate the css for the incognito or normal mode.  Since
the NTP only needs one, we only need to generate one.

BUG=26228

Review URL: http://codereview.chromium.org/344027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30527 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/346015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30526 0039d316-1c4b-4281-b951-d872f2087c98

This also backs out r26610 (these are the changes to host_resolver_impl.cc), since that code is no longer necessary if LoadLog is refcounted thread safe.

LoadLog itself is not thread safe -- however making its refcounting threadsafe simplifies passing it across thread boundaries.

Initially I had avoided doing this, and instead was trying to be very careful in when callers would AddRef/Release to avoid races.
This approach however turned out to be fragile, and it was difficult to chase down all of the dependencies (they just kept popping up).
So now I am changing that decision, and opting for the simpler approach which will be much more robust.

The performance impact should be negligable.

BUG=22272

Review URL: http://codereview.chromium.org/347021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22549
TEST=none

Review URL: http://codereview.chromium.org/344028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25099
TEST=See 337010.

Review URL: http://codereview.chromium.org/343042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26239
TEST=launch browser, look at border under toolbar, open findbar

Review URL: http://codereview.chromium.org/339074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30522 0039d316-1c4b-4281-b951-d872f2087c98

- Fix extension_service_unittest to actually load extensions from prefs.

BUG=19733
TEST=Remove extension manifest from Preferences file. Extension shouldn't load even if the necessary files are present.
Review URL: http://codereview.chromium.org/339058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30521 0039d316-1c4b-4281-b951-d872f2087c98

1. A window.open call issued from a page within ChromeFrame in IE full tab mode makes it back
   to IE before being shunted into Chrome.
2. Brings up the chrome frame context menu in full tab mode and invokes the About Chrome frame 
   option.

While I was working on these tests based on a lot of help from Stoyan, we had these tests use gmock
and I also changed the disallowed URL test to use gmock.

The other changes are to always run the chrome frame tests in the STA apartment as the newly added
full tab mode tests cannot handle calls coming in from background RPC worker threads.

Bug=26066,26172

Review URL: http://codereview.chromium.org/340029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30520 0039d316-1c4b-4281-b951-d872f2087c98

Use the new SearchVersusNavigateClassifier in BrowserRootView.  Patch by Thiago Farina (see http://codereview.chromium.org/347020 ), r=me, tweaked.

BUG=21317
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30519 0039d316-1c4b-4281-b951-d872f2087c98

Minor position changes to the CSS to make the page
match the other pages better when flipping
betwen the downloads, history and extensions page.

BUG=http://crbug.com/26120
TEST=Flip between History and Downloads page and
the icon and the header section should line up
and be the same size on all three pages.
Review URL: http://codereview.chromium.org/339073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30518 0039d316-1c4b-4281-b951-d872f2087c98

  BUG=none
  TEST=none
  R=tony@chromium.org

Review URL: http://codereview.chromium.org/341040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30517 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=26068

Review URL: http://codereview.chromium.org/342024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/342041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30515 0039d316-1c4b-4281-b951-d872f2087c98

its own file, and have it carry a FlipStream pointer.

The PrioritizedIOBuffer was more generic, but after we queued IO,
we couldn't track which stream should be notified about the IO
completion.  Having it carry the FlipStream pointer will enable
IO tracking, but with a FlipStream pointer, it is really specific
to Flip, so I renamed to FlipIOBuffer.  I could have kept a generic
(void*) pointer (or used a template), but that seemed unnecessary
in this case.

This CL just changes the refactoring.  Will remove the
PrioritizedIOBuffer next.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/341032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30514 0039d316-1c4b-4281-b951-d872f2087c98

Pickup:
  731) -fPIC fix for scons generator
  732) shared library fix for cross-compiling
  734) support for configuration inheritance.

BUG=300013
TEST=try server.

Review URL: http://codereview.chromium.org/343043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30513 0039d316-1c4b-4281-b951-d872f2087c98

Remove the element_ member of FormField, as we don't use it and shouldn't be using WebCore internals in glue anyway.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26173

Review URL: http://codereview.chromium.org/345022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30511 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30509 0039d316-1c4b-4281-b951-d872f2087c98

If we remove a search engine from our prepopulate data, remove it from the user's list too if they haven't edited it or made it default.

BUG=none
TEST=Covered by unittest
Review URL: http://codereview.chromium.org/339071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30508 0039d316-1c4b-4281-b951-d872f2087c98

Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily).

http://crbug.com/26231
TEST=interactive ui tests, standard find tests

Review URL: http://codereview.chromium.org/348015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30507 0039d316-1c4b-4281-b951-d872f2087c98

Patch from Kelly Norton <knorton@google.com>

TBR=mpcomplete@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30506 0039d316-1c4b-4281-b951-d872f2087c98