BUG=66453
TEST=none

Review URL: http://codereview.chromium.org/5762002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5816001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65298
TEST=none

Review URL: http://codereview.chromium.org/5753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69129 0039d316-1c4b-4281-b951-d872f2087c98

- in STL vector<> has no data() member.

BUG=None
TEST=Builds. base_unittest --gtest_filter=*Sym*

Review URL: http://codereview.chromium.org/5705006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69128 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5719005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=change linux policy and check that it's refreshed

Review URL: http://codereview.chromium.org/5732002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9959
TEST=Manual.

Review URL: http://codereview.chromium.org/5713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69125 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8282
TEST=manual

Review URL: http://codereview.chromium.org/4134013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65298
TEST=Builds

Review URL: http://codereview.chromium.org/5767005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69123 0039d316-1c4b-4281-b951-d872f2087c98

Also CL contains changes which unify communication between
|UserController| and corresponding controls view (UserInput interface).

BUG=chromium-os:9770
TEST=Play with login. Notice appearing spinners.

Review URL: http://codereview.chromium.org/5709001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69122 0039d316-1c4b-4281-b951-d872f2087c98

This includes temporary test_expectations, will push a fix to webkit later today.

Review URL: http://codereview.chromium.org/5805003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69121 0039d316-1c4b-4281-b951-d872f2087c98

Set correct parent window for proxy settings: "under the hood", not "network settings".
Remove close button when invoked at OOBE screen because there already exists another close button.

BUG=chromium-os:10035
TEST=Manual

Review URL: http://codereview.chromium.org/5790001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61409
TEST=trybots

Review URL: http://codereview.chromium.org/5730004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:3412,chromium-os:3292
TEST=On a ChromeOS device, file://media should now be accessible.

Review URL: http://codereview.chromium.org/5785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69113 0039d316-1c4b-4281-b951-d872f2087c98

at the same time.

I am removing traces from two tests since I think the problem with those
tests have been fixed. By suppressing the crash server window on the try
servers and ensuring Chrome is in the foreground it looks like the test now
works. I went back in time through pages of try server logs and it seems to
work.

I am also enabling my other test that was disabled at the same time, since
I think that test will probably work now. I moved the window caption check
to that file, so we can see if we still have the same problem when it fails.

BUG=62936, 62937
TEST=This CL is all about tests.

Review URL: http://codereview.chromium.org/5769003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69112 0039d316-1c4b-4281-b951-d872f2087c98

Explicitly cast the returned value into the void. Clang complains
about this unused return value otherwise.

BUG=none
TEST=flip_in_mem_edsm_server

Review URL: http://codereview.chromium.org/5727003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69111 0039d316-1c4b-4281-b951-d872f2087c98

Suppress remoting_ Valgrind leaks; s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory waterfall redness after r69076
TBR=glider
TEST=./tools/valgrind/waterfall.sh
BUG=66808
Review URL: http://codereview.chromium.org/5777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66808
TBR=glider
TEST=heapchecker bot should go greener
Review URL: http://codereview.chromium.org/5748007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69109 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69108 0039d316-1c4b-4281-b951-d872f2087c98

Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.

As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.

There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5682008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98

I tried to repro this bug and could not.  Seems to work.

BUG=58553,28083
TEST=python chrome/test/functional/cookies.py cookies.CookiesTest.testCookiesFile

Review URL: http://codereview.chromium.org/5721007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69106 0039d316-1c4b-4281-b951-d872f2087c98

- Shorten the signature for the crash in bug 66741.

TBR=thestig@chromium.org
BUG=66795
TEST=none
Review URL: http://codereview.chromium.org/5697009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69105 0039d316-1c4b-4281-b951-d872f2087c98

mode.

BUG=66118
TBR=none

Review URL: http://codereview.chromium.org/5707009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69104 0039d316-1c4b-4281-b951-d872f2087c98

where this dependency comes from.

TBR=amit
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5757004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5767004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69102 0039d316-1c4b-4281-b951-d872f2087c98

in ChromeFrame now takes in an interface NavigationConstraints which allows the delegateslike
the ActiveX, ActiveDocument and the NPAPI plugins to control the navigation decisions.

We no longer refer to the InternetSecurityManager interface which is IE only for performing
zone decisions in the ChromeFrame NPAPI plugin.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=66118

BUG=66118
TEST=Covered by additional CanNavigate unit tests.

Review URL: http://codereview.chromium.org/5698005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests

Review URL: http://codereview.chromium.org/5510006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69096 0039d316-1c4b-4281-b951-d872f2087c98

I don't see this on the ChromiumOS bots anymore.  I'm hoping it's either gone away, or it will turn a bot red quickly so I can analyze the problem.

BUG=62674
TEST=none

Review URL: http://codereview.chromium.org/5737006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69095 0039d316-1c4b-4281-b951-d872f2087c98

It used to be possible to navigate to a dnagerous file type to trigger its
download. Not anymore. Now all downloads where the user initiated it (by
navigating to a URL or clicking on a link) are not marked unsafe even for
unsafe filetypes.

Update the tests to trigger dangerous downloads by navigating to a file which
in turn triggers the dangerous files to download.

BUG=66081, 57875

Review URL: http://codereview.chromium.org/5781006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69093 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69091 0039d316-1c4b-4281-b951-d872f2087c98

Revert 69088 - Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager.

BUG=58576
TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes

Review URL: http://codereview.chromium.org/5322001

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/5682012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60243
TEST=none

Review URL: http://codereview.chromium.org/5633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69089 0039d316-1c4b-4281-b951-d872f2087c98

Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager.

BUG=58576
TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes

Review URL: http://codereview.chromium.org/5322001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69088 0039d316-1c4b-4281-b951-d872f2087c98

This change adds an explicit call to |hidePopups| when no username/password completion matches the contents of the username text field.

BUG=65985
TEST=Manual, according to bug steps.

Review URL: http://codereview.chromium.org/5726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69086 0039d316-1c4b-4281-b951-d872f2087c98

Split the layout tests run in the appcache ui tests into two groups, PHP dependent vs non-dependent. Also remove some tests that are racey from the layout tests run in these test cases.

BUG=54717
TEST=yes

Review URL: http://codereview.chromium.org/4858003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/5794003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98

According to,
http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKit/chromium/public/WebFrame.h
WebFrame::dispatchWillSendRequest is now deprecated.  Updating to use createAssociatedURLLoader() instead.

BUG=65806
TEST=media

Review URL: http://codereview.chromium.org/5515008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69083 0039d316-1c4b-4281-b951-d872f2087c98

This adds some plumbing for propagating the status and error code of a renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash.

Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done:

- Changed the name of DidProcessCrash to GetTerminationStatus.
- Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus.
- Improved process_util_unittest to actually test for crashing and terminated processes on all platforms.
- Added a new notification for renderers that were killed.
- Added error code information to crash notification.
- Added status and error code information to renderer IPC message for RenderViewGone.
- Added a UMA histogram count for number of renderer kills.

BUG=http://crosbug.com/8505
TEST=ran new unit test. Test passes on try servers.

Review URL: http://codereview.chromium.org/5172009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98