- Dec 14, 2010
-
-
avi@chromium.org authored
BUG=66453 TEST=none Review URL: http://codereview.chromium.org/5762002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69131 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
BUG=none TEST=change linux policy and check that it's refreshed Review URL: http://codereview.chromium.org/5732002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69126 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 13, 2010
-
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 11, 2010
-
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 10, 2010
-
-
danno@chromium.org authored
BUG=66102, 66054 TEST=valgrind on linux and mac Review URL: http://codereview.chromium.org/5748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68844 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 09, 2010
-
-
http://codereview.chromium.org/5519016/satish@chromium.org authored
This is a continuation of http://codereview.chromium.org/5519016/, adds a new GetInstance() method for remaining files with singleton classes under chrome/browser. For types declared and used within the same .cc file, I changed them over to LazyInstance<T>. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5711001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68739 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
This reworks the PrefStore interface, specifically: - Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store - Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations - Remove special handling of default and user pref store from PrefValueStore and put it into PrefService - Pref change notification handling now almost exclusively handled through PrefValueStore - Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list) BUG=64232 TEST=existing unit tests Review URL: http://codereview.chromium.org/5646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
Create a superclass of FileBasedPolicyProvider that abstracts how a provider can provide policy on the UI thread that is loaded from the FILE thread. BUG=65094 TEST=AsynchronousPolicyProvider.* Review URL: http://codereview.chromium.org/5562002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68735 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 08, 2010
-
-
erg@google.com authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically: - Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore. - Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore. - Clean up related unit tests, removing redundant mocks and gmockify others. BUG=64893 TEST=Compiles and passes tests Review URL: http://codereview.chromium.org/5441002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 07, 2010
-
-
erg@google.com authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 05, 2010
-
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68323 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 02, 2010
-
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68074 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 01, 2010
-
-
mnissler@chromium.org authored
BUG=none TEST=Compiles and passes tests. Review URL: http://codereview.chromium.org/5448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67848 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 30, 2010
-
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 29, 2010
-
-
danno@chromium.org authored
Device token/id should be erased when device management sever reports "not managed" from policy request. BUG=64613 TEST=DeviceManagementPolicyProviderTest.DeviceNoLongerManaged Review URL: http://codereview.chromium.org/5346005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67600 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
This is necessary backend work for fixing bug 64314 (make login wait only for the first registration check). It also enables subsequent polling of the DM server at defined intervals (rather than at each login, or never). BUG=64314 TEST=unit tests: DeviceManagementPolicyProviderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67530 Review URL: http://codereview.chromium.org/5331008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67535 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
This is necessary backend work for fixing bug 64314 (make login wait only for the first registration check). It also enables subsequent polling of the DM server at defined intervals (rather than at each login, or never). BUG=64314 TEST=unit tests: DeviceManagementPolicyProviderTest.* Review URL: http://codereview.chromium.org/5331008 TBR=jkummerow@chromium.org Review URL: http://codereview.chromium.org/5321011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67531 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
This is necessary backend work for fixing bug 64314 (make login wait only for the first registration check). It also enables subsequent polling of the DM server at defined intervals (rather than at each login, or never). BUG=64314 TEST=unit tests: DeviceManagementPolicyProviderTest.* Review URL: http://codereview.chromium.org/5331008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67530 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 26, 2010
-
-
danno@chromium.org authored
BUG=64430 TEST=POST request closer to reference implementation Review URL: http://codereview.chromium.org/5388001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67444 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
BUG=64318 TEST=DeviceManagementPolicyProviderTest.DeviceNotFound Review URL: http://codereview.chromium.org/5341004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67440 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 25, 2010
-
-
gfeher@chromium.org authored
Make DeviceTokenFetcher wait until the name of the logged-in user is broadcasted, and only allow registering at DMServer if the user has a non-gmail address. BUG=62477 TEST=DeviceTokenFetcherTest.FetchBetweenTokenNotifyAndLoginNotify,DeviceTokenFetcherTest.FetchWithNonDasherUsername Review URL: http://codereview.chromium.org/4960003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67412 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=None TEST=compiles and passes tests Review URL: http://codereview.chromium.org/5293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67406 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 24, 2010
-
-
jkummerow@chromium.org authored
• Move device management protocol constants into shared header file • Filter out policies with unwanted keys when decoding server response This also fixes bug 62058. BUG=62481 TEST=existing unit tests still work: DeviceManagementPolicyProviderTest.*:DeviceTokenFetcherTest.* Review URL: http://codereview.chromium.org/5348001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67259 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
Add actions for mock device management backend for request success and failure. BUG=62482 TEST=DeviceManagementPolicyProviderTest*:DeviceTokenFetcherTest* Review URL: http://codereview.chromium.org/5338004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67255 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 23, 2010
-
-
mnissler@chromium.org authored
This renames DeviceManagementBackendRequestContext(Getter) to DeviceManagementRequestContext(Getter), actually instantiates it and updates a comment. BUG=63608 TEST=compiles and passes tests Review URL: http://codereview.chromium.org/5292003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67114 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
Also, this takes care of retrying when policy fetching fails. BUG=62487 TEST=unit tests: DeviceManagementPolicyProviderTest.*:DeviceTokenFetcherTest.* Review URL: http://codereview.chromium.org/5219006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67091 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 22, 2010
-
-
mnissler@chromium.org authored
While at it, clean up use of policy constants. BUG=62060 TEST=Compiles and passes existing tests. Review URL: http://codereview.chromium.org/5162006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66949 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
Move responsibility for creating backend objects to a device management service object that lives in the profile. Doing allows us to make use of the profile's request context, which has the advantage over the independent request context implementation that stuff is more efficient (i.e. we need to only resolve the proxy once). BUG=63608 TEST=device_management_service_(unit|browser)test.cc Review URL: http://codereview.chromium.org/5153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66948 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5212005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66930 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 19, 2010
-
-
mnissler@chromium.org authored
Previously, we used only one provider, which would break in situations where there are two profiles (which ChromeOS already does), because it would apply the policy to both profiles and not only the logged in one. For this to work properly, we also need to pass the relevant TokenService instance the DeviceTokenFetcher, so the fetcher can decide whether the token is relevant to it by checking whether the TokenService that sent it is the one associated with the right profile. BUG=63608 TEST=existing unit tests succeed Review URL: http://codereview.chromium.org/5174006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66755 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 18, 2010
-
-
agl@chromium.org authored
This reverts commit r66623. Some how it causes libnspr4.dll to be linked in Chrome Frame builds. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66687 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
DnsCertProvenanceChecker is introduced to abstract away the action of uploading reports. It's implemented by ChromeDnsCertProvenanceChecker which lives in a scoped_ptr off of a URLRequestContext. It's only active on the main context (i.e. not in incognito mode). This might change in the future, but it's a nice, conservative choice for the moment. The DnsCertProvenanceChecker is plumbed all the way to SSLClientSocket (via HttpCache) where it replaces the DnsRRResolver. Above SSLClientSocket, it's plumbed in addition to the DnsRRResolver because the later will end up going into SSLHostInfo in the future. At the moment, ChromeDnsCertProvenanceCheckerContext is just a skeleton to avoid putting too much real code in a plumbing job. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66623 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 17, 2010
-
-
markusheintz@chromium.org authored
BUG=63469 TEST=none Review URL: http://codereview.chromium.org/5118003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66456 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
BUG=62476 TEST=unit_tests: DeviceTokenFetcherTest.UnmanagedDevice Review URL: http://codereview.chromium.org/4967005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66440 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
BUG=62798 TEST=unit tests: DeviceTokenFetcherTest.StoreAndLoad Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66415 Review URL: http://codereview.chromium.org/4949003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66435 0039d316-1c4b-4281-b951-d872f2087c98
-
markusheintz@chromium.org authored
BUG=62478 TEST=PrefValueStore*:PrefService* Committing for danno@chromium.org Review URL: http://codereview.chromium.org/4876002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66426 0039d316-1c4b-4281-b951-d872f2087c98
-