- Dec 15, 2010
-
-
jianli@chromium.org authored
TBR=yurys BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69337 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Create a ResourceMessageFilter to filter resource related IPCs. This gets rid of the awkward ResourceDispatcherHost::Receiver interface and allows a bunch of cleanup. I've also generalized the filtering done in WorkerProcessHost and moved it to ChildProcessHost (since it's now used to add the ResourceMessageFilter). Review URL: http://codereview.chromium.org/5874002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69335 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
Newer versions of Cairo assert if the surface isn't flushed before it is marked dirty but this should be done anyway to ensure correct layering of draw operations. BUG=65692 TEST=No crash on Maverick (Ubuntu 10.10) Review URL: http://codereview.chromium.org/5737004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69334 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69333 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
- tie "edit" mode to "selected" -- selecting enters into edit mode -- blurring exits edit mode and deselects - fix up layout within rows (faux columns) - add a special "add new exception" row (this should be at the bottom of the table, but it's currently at the top) - change behavior when the user attempts to commit an invalid exception. Instead of trying to regrab focus, just revert the row to its previous state. TODO: list should be sized dynamically, i.e. no scrollbar. TODO: list should be in sub-sub dialog TODO: rows should have delete X BUG=64153 TEST=manual Review URL: http://codereview.chromium.org/5699004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69332 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=61340 TEST=Opening up the task manager on Linux in debug mode does not assert. Review URL: http://codereview.chromium.org/5928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69331 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Revert 69320 - Migrate HostReferralList and StartupDNSPrefetchList from local_state to user preferences, in preparation for multi-profile. BUG=66717 TEST=none. Review URL: http://codereview.chromium.org/5800004 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/5921003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69327 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
eglapi.c:276: warning: cast to pointer from integer of different size TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/5921002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69325 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=50307 TEST=Zoom out in slomo. Favicon and tab titles should fly in like the thumbnails. Zoom back in, they should still look correct. Review URL: http://codereview.chromium.org/5764002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69323 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
TBR=yurys BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69322 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69321 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Migrate HostReferralList and StartupDNSPrefetchList from local_state to user preferences, in preparation for multi-profile. BUG=66717 TEST=none. Review URL: http://codereview.chromium.org/5800004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69320 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
Adjust OTR guy up a bit to avoid the border, give him a shadow (for reals; setShadow on NSView doesn't work if the view has no layer). BUG=66757 TEST=OTR guy should not block divider line and should have a slight shadow around him Review URL: http://codereview.chromium.org/5905001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69319 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/5921001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69318 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Turns out that the bot might be running an http server which can lead to redirects and mess up the test. Use a url at a port which is unlikely to be active. Review URL: http://codereview.chromium.org/5861003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69317 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
BUG=66741 TEST=none Review URL: http://codereview.chromium.org/5858002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69316 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=58235 TEST=none Review URL: http://codereview.chromium.org/5579002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69315 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
Also removing the system_level() property out of the Product class and into the Package class as system_level can't be different for products that share the same package. TEST=Run installer and unit tests. BUG=61609 Review URL: http://codereview.chromium.org/5744001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69314 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/5877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69313 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/5865002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69311 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
BUG=chromium-os:10209 TEST=Run sync tests, and confirm that sync is enabled after login for all types of login on ChromeOS Review URL: http://codereview.chromium.org/5792001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69310 0039d316-1c4b-4281-b951-d872f2087c98
-
neb@chromium.org authored
Mostly done by bbudge. BUG=none TEST=ppapi_include_tests.py Review URL: http://codereview.chromium.org/5837001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69309 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=65665 TEST=Open a subpage, click on a control in it, and then press esc. The subpage should close. Review URL: http://codereview.chromium.org/5916001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69308 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Previously, DiskCacheBasedSSLHostInfo had a couple of problems: * I had assumed that the disk cache was taking references to the callback. It wasn't. * Even if it were, I was passing pointers into DiskCacheBasedSSLHostInfo which needed to be live for the duration of the callback. This change switches to a custom callback class which doesn't need reference counting and which contains pointer members that remain live for the duration of the callback. BUG=63867 TEST=Navigate to an HTTPS page with Snap Start running and no network connection. http://codereview.chromium.org/5826001/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69305 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
- Verify that Chrome sets the extended attributes on a file so when its launched in the Finder and we are warned. - Download the same zip file in regular and incognito window and verify that it downloaded correctly with same file name appended with counter for the second download in regular window. Also verify that the download shelf showed up in each window. Review URL: http://codereview.chromium.org/5855001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69302 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
BUG=66733 TEST=browser_tests with positive and negative filter strings (i.e. --gtest_filter=Positive, --gtest_filter=Positive-Negative, --gtest_filter=-Negative etc) Review URL: http://codereview.chromium.org/5712010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69300 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
The search_engines test when run in the google network might timeout because of the invalid urls used. Use localhost instead so that it goes fast. BUG=64264 TEST=search_engines.py Review URL: http://codereview.chromium.org/5832003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69299 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
Upon WrenchMenu SignOut on ChromeOS, respect onbeforeunload/onunload handlers, and ongoing downloads. Check if beforeunload/unload handlers and ongoing downloads exist. If they do not, signal ChromeOS to halt immediately, otherwise, shutdown the browser gracefully before shutting down ChromeOS. BUG=chromium-os:8328,chromium-os:8178 TEST=Go to achuithz600/achuith/test/onunload.html, open wrench menu and sign out. A popup should appear and cancel the signout. Go to achuithz600/achuith/large_files/, download the file, and during the download, ctrl-shift-q. A popup should appear to cancel the signout. If you choose not to cancel, the system should restart without Chrome crashing. If you choose to cancel, ChromeOS should halt the signout process. Review URL: http://codereview.chromium.org/4833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69298 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=chromium-os:9812 TEST=Manual. Review URL: http://codereview.chromium.org/5708001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69293 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/5901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69291 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
Added constants for NaCl. Register plugin (only if --enable-nacl) BUG= http://code.google.com/p/nativeclient/issues/detail?id=933 TEST=none Original patch by Noel Allen. Review URL: http://codereview.chromium.org/5848001/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69290 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
Review URL: http://codereview.chromium.org/5905002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69288 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69287 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
BUG= http://code.google.com/p/nativeclient/issues/detail?id=933 TEST=none Original patch by Noel Allen. Review URL: http://codereview.chromium.org/5740007/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69285 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
And fix the users. BUG=23581 Review URL: http://codereview.chromium.org/5774005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69284 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@chromium.org authored
BUG=chromium-os:9790 TEST=Manual. Followed steps in bug to make sure crash no longer happens. Review URL: http://codereview.chromium.org/5722008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69283 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
omnibox. If the height grows, the page is told immediately, otherwise we delay a second. This helps avoid having results obscured, as well as having the page dance around if the omnibox is changing. BUG=65596 TEST=none Review URL: http://codereview.chromium.org/5898002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69282 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=56736 TEST=none Review URL: http://codereview.chromium.org/5794006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69281 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
created before sending back their info. BUG=65408,66072 TEST=none Review URL: http://codereview.chromium.org/5718002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69280 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: http://codereview.chromium.org/5779006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69279 0039d316-1c4b-4281-b951-d872f2087c98
-