- Jan 12, 2011
-
-
stuartmorgan@chromium.org authored
Validation feedback still needs polish, but this is completely functional, so I'll leave that for a follow-up. This introduces a new shared class for editable lists; we should migrate the existing editable lists to it, expanding as necessary, but I didn't want to make this patch too unwieldly. BUG=63825,61742 TEST=Search engines should be editable and addable inline in DOMUI prefs. Review URL: http://codereview.chromium.org/6151004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71121 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
fail to load resources.pak. This allows us to collect more UMA stats. BUG=58056 TEST=Delete resources.pak and start chrome. It shouldn't crash. Review URL: http://codereview.chromium.org/6123006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71117 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
crashing. I can only see this crash happening if the opener ends up equal to contents, but that doesn't seem possible in code. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/6124009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71116 0039d316-1c4b-4281-b951-d872f2087c98
-
davej@chromium.org authored
If PulseAudio is running, everything should behave as before, otherwise use ALSA API for adjusting volume. The previous PulseAudioMixer was split into AudioMixerBase and audioMixerPusle, then AudioMixerAlsa was added. BUG=chromium-os:10470 TEST=Volume keys should work even if pulseaudio disabled Review URL: http://codereview.chromium.org/5859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71115 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
Currently we get memory information for about:memory using /bin/ps. Unfortuantely ps doesn't give us information about shared and private memory. Also, it's total virtual memory value doesn't match Activity Monitor's. This change adds code to get memory information using /usr/bin/top. The new code falls back to ps if there's a parsing error. Once about:memory displays all the information we need there are still a couple of things left to do: - refactor ProcessInfoSnapshot to use ProcessMetrics where possible - do a better job of detecting shared objects between our child processes and show it some how BUG=25454 TEST=Opened about:memory and verified that the values matched those in Activity Monitor. Tested on both 10.6 and 10.5. Review URL: http://codereview.chromium.org/6052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71114 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71113 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
WebGraphicsContext3DDefaultImpl from WebKit repository. BUG=none TEST=built test_shell on Linux Review URL: http://codereview.chromium.org/6153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71108 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 11, 2011
-
-
tfarina@chromium.org authored
BUG=None TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples out/Debug/views_examples Go to the table tab. Click on one of the checkboxes, you shouldn't see an ERROR for this method. Review URL: http://codereview.chromium.org/6175002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71106 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71105 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/6216003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71104 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=none TEST=none TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71103 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=None TEST=Change the lead selection in DOMUI pref lists; there should be a top and bottom border. Review URL: http://codereview.chromium.org/6198005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71102 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
1. Change hide message from 'Hide this message' to 'No thanks, hide this'. 2. Hide promo text when a default app is launched (this was already happening on uninstall). 3. Uninstall default apps when promo expires or is purposefully hidden. 4. Collapse apps section when promo expires or is purposefully hidden. BUG=67292,69268 TEST=none Review URL: http://codereview.chromium.org/6162006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71100 0039d316-1c4b-4281-b951-d872f2087c98
-
lzheng@chromium.org authored
TEST=none BUG=69280 Review URL: http://codereview.chromium.org/6097014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71098 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
When performing TLS client auth with an HTTPS proxy, disable TLS false start to better handle SSL handshake failures, such as the HTTPS proxy requiring a client certificate. In addition, when an HTTPS proxy fails, ensure that it is removed from the SSL client auth cache, so that if the failure was due to an invalid client certificate, the user can be prompted to select one again. Depends on: http://codereview.chromium.org/6017010 Patch by: Ryan Sleevi BUG=66424 TEST=HttpNetworkTransactionTest.Proxy_ClientAuthCertCache git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71096 0039d316-1c4b-4281-b951-d872f2087c98
-
nfullagar@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71095 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@google.com authored
Adds the x-nacl to the MIME types recognized by the Pepper NaCl plug-in. Another CL will remove the old MIME type (x-ppapi-nacl-srpc) after the NaCl tree has been updated, to avoid a window where NaCl is broken. BUG=none TESTS=manual Review URL: http://codereview.chromium.org/6117005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71094 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Add some tests (for aborting calls). Also fix Flash NetConnector callback running. BUG=none TEST=ppapi_tests Review URL: http://codereview.chromium.org/6228004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71092 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
These 2 just needed a new baseline given their updated results. - vista-release-single-core/intl2/times/t - xp-release-single-core/dhtml/times/t BUG=none TEST=perf steps are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/6144004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71091 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
It should now match the mocks modulo the adobe flash settings link (not sure why the mocks show it as a checkbox; AFAIK making it a checkbox is outside our ability to do). also make it work (the time period select dropdown was broken). BUG=69163,63843 TEST=manual Review URL: http://codereview.chromium.org/6110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71090 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
This change localizes the Autofill heuristics regular expressions pertaining to credit card information. BUG=55787 TEST=FormStructureBrowserTest.HTMLFiles Review URL: http://codereview.chromium.org/6113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71089 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@google.com authored
Review URL: http://codereview.chromium.org/6115008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71085 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
BUG=None TEST=None TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6142012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71084 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/6130007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71082 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=None TEST=compiles on VS2005 Review URL: http://codereview.chromium.org/6198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71081 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
of 32/64 bits, as they have been causing out of memory errors even on 64-bit builders.: chrome_frame_tests chrome_frame_perftests chrome_dll_nacl_win64 browser_tests nacl_ui_tests nacl_sandbox_tests sync_integration_tests interactive_ui_tests BUG=none TEST=it builds Review URL: http://codereview.chromium.org/6113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71077 0039d316-1c4b-4281-b951-d872f2087c98
-
eblake@chromium.org authored
Review URL: http://codereview.chromium.org/6233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71075 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
If an SSL handshake fails when client certificates are used, ensure that the client certificate selected is removed from the SSL client auth cache. This ensures that the user is prompted to select a certificate again, as the cause of the failure may have been due to selecting the wrong certificate or selecting no certificate when one is required. The existing logic worked when TLS False Start was disabled, but could fail when False Start was used or when the peer requests renegotiation. This changes ensures the client certificate is removed from the cache by moving the cache removal layer from the HttpStreamRequest to the HttpNetworkTransaction. Patch by: Ryan Sleevi BUG=66424 TEST=HttpNetworkTransactionTest.ClientAuthCertCache* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71071 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
BUG=None TEST=None TBR=thakis Review URL: http://codereview.chromium.org/6132008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71070 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
Chromium repository to break circular dependencies on Chromium's OpenGL bindings in app/gfx/gl. The minimal changes to the code were made in order to break dependencies on WebCore types and to make the code fit the Google C++ style guide as closely as possible. There are many references to undesirable types like "long" in the WebGraphicsContext3D interface, which are the source of the majority of lint errors and which will be fixed in follow-on work. The upstream WebGraphicsContext3DDefaultImpl will be deleted after this lands. Tested: - Various WebGL demos in Chrome - Built and ran WebGL layout tests in DRT BUG=none TEST=none (see above) Review URL: http://codereview.chromium.org/6100009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71069 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
http://trac.webkit.org/changeset/75484/ (rolled with r71043). TBR=jschuh git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71068 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
make OnCallback() static to prevent the CompositeFilter from becoming owned by other filter threads. BUG=68784 TEST=None Review URL: http://codereview.chromium.org/6226001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71067 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
TBR=joi@chromium.org BUG=68516 TEST=none Review URL: http://codereview.chromium.org/6109008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71066 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6155007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71065 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Calls ChromeURLRequest::IsExternal() inside ResourceDispatcherHost to see if the URLRequestContext was a valid ChromeURLRequestContext at the point when it was set. BUG=68766 Review URL: http://codereview.chromium.org/6094017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71064 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
otherwise causes subtle problems with extensions and breaks the invariant that the tab id is unique. BUG=68508 TEST=none Review URL: http://codereview.chromium.org/6155003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71063 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
Enable GpuPixelBrowserTest.WebGLTeapot and add a test option for picking a custom directory for generated images. BUG=59131 TEST=none Review URL: http://codereview.chromium.org/6173007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71062 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
NO CODE CHANGE. TBR=abarth BUG= TEST= Review URL: http://codereview.chromium.org/6196005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71061 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
Rework how bookmark bar folder menus and submenus are layed out when scrolling, adding and removing bookmarks and during drag and drop operations. Make a subfolder menu appear as much on screen as possible. Changed to the BookmarkBarFolderWindow.xib: Added view (visibleView_) between the window's content view and the rest of the content. Added scroll-up arrow and scroll-down arrow views. Added connections to controller of all views within the window. BUG=54701 TEST=Test submenu appearance by creating a folder menu with lots of items with the bottom-most item being a sub-folder with several bookmark items of its own. Place the browser window such that the bookmark button for the sub-folder will appear near the bottom of the screen. Pop up the folder menu then pop up the sub-menu and verify that the sub-menu is shown on screen and does not require scrolling. In all following cases of adding or removing bookmarks, either by using the contextual menus (cut/copy/paste/delete) or by dragging and dropping, verify that the top of the folder menu and the menu items (bookmark buttons) above the location of the addition/removal remain in the same position vertically on the screen; menu items below the affected bookmark should move upward (for a removal) or downward (for an addition) and the scroll-up arrow (the one at the bottom of the menu) should hide or show as appropriate. Verify that dragging or pasting a wide menu item into a narrow folder menu causes the menu to widen. Verify that cutting or deleting a wide menu item from a folder menu will cause the menu to narrow. Perform the listed tests for each of the folder menu arrangements. Folder menu arrangements ------------------------ 1. Folder with no items (one showing 'empty') 2. Folder with just a few items and neither the scroll-up or scroll-down arrow showing. 3. Folder with enough items such that adding one more should cause the scroll-up arrow to show. 4. Folder with enough items and the scroll-up arrow showing such that removing one item should cause the scroll-up arrow to hide. 5. Folder with enough items that the scroll-up arrow shows but after fully scrolling the menu fits completely on screen without any scrolling arrows showing. 6. Folder with enough items that the scroll-up arrow shows and can be scrolled up such that both scroll-up and scroll-down arrows can show with plenty of extra items. Tests ----- 1. Cut a bookmark menu item. 2. Paste an item. 3. Paste another item. 4. Drag an item to a different place within the same folder menu. 5. Drag an item to a different folder menu (one each of those listed above). 6. Cut the first item. 7. Cut the last item. 8. Paste to the last item. For scrollable arrangements #5 and #6: 9. Scroll up only a little (such that the scroll-down arrow does not appear) and cut an item. 10. Scroll up only a little (such that the scroll-down arrow does not appear) and paste an item. For scrollable arrangement #6: 11. Scroll up so that both the scroll-up and scroll-down arrows appear and cut an item. 12. Scroll up so that both the scroll-up and scroll-down arrows appear and paste an item. Review URL: http://codereview.chromium.org/5694001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71059 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
The sync integration tests were using a timeout of 30 seconds for live operations. Some of the sync stress tests are timing out because it takes longer for a full sync cycle to complete. This patch increases the timeout to 45 seconds in profile_sync_service_harness.cc, and is expected to eliminate the occasional failures on the builders. TBR=tim@chromium.org BUG=68207 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6125006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71058 0039d316-1c4b-4281-b951-d872f2087c98
-