- Sep 15, 2009
-
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/193115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26261 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/193032sky@chromium.org authored
First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Review URL: http://codereview.chromium.org/194118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26255 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=dglazkov TEST=none BUG=none Review URL: http://codereview.chromium.org/195092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26254 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
1) Tell the AppCacheService which request context to use when fetching resources for updates. Done for both chrome and test_shell. The service does not yet take a reference to that context, because the extra reference apparently gives some tests grief. 2) Added methods to generate new storage ids for different object types on the IO thread. BUG=none TEST=none Review URL: http://codereview.chromium.org/195077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26253 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
The "make default" button Auto size to always fit the text. Be a small style control, look better (changes font). General fix up so the window resizes. TableView Turn off column select Turn off multiple selection (code doesn't support it on delete). Update the xib for the class name change that happened as part of the prior commit. BUG=21892 TEST=window resize correctly, make default button fits it's text for all languages. Review URL: http://codereview.chromium.org/206016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26252 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Revert "Added NVALGRIND define [on by default]. Can be turned off on valgrind slaves by using valgrind_build=1" This reverts commit 26241. (Testing to see if it greens the Linux Valgrind builder.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26251 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/178036paul@chromium.org authored
by Vassili Bykov. BUG=19983 TEST=Follow the steps in the bug to test the bubble's move-out-of-the-way behavior with dowload shelf both visible and hidden. Review URL: http://codereview.chromium.org/200135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26250 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This reverts commit r26234. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26249 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
BUG=19763 TEST=per bug. This might not appear to work given how LaunchServices caches and registers applications. You may need to test on a totally clean machine. Review URL: http://codereview.chromium.org/194116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26248 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@google.com authored
-Add a view of skipped tests for that platform -Don't mark tests that timeout as needing a SLOW modifier. -Show date and webkit/chrome blamelists when you click on results -Show a line for when a webkit merge happens. Review URL: http://codereview.chromium.org/195081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26247 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
[Mac] Make the pageup, Shift-pageup, and Option-Shift-pageup keys scroll the underlying webpage when using the findbar. BUG=http://crbug.com/17421 TEST=Try pressing pageup with focus in the findbar. Review URL: http://codereview.chromium.org/204006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26246 0039d316-1c4b-4281-b951-d872f2087c98
-
dank@chromium.org authored
BUG=21890 TEST=valgrind ui bot doesn't hang Review URL: http://codereview.chromium.org/196127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26245 0039d316-1c4b-4281-b951-d872f2087c98
-
jon@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26244 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Also a slight variation on an existing font suppression. BUG=20508,20580 TEST=Mac valgrind UI bots Review URL: http://codereview.chromium.org/195089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26242 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Added NVALGRIND define [on by default]. Can be turned off on valgrind slaves by using valgrind_build=1 Review URL: http://codereview.chromium.org/195078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26241 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/203072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26239 0039d316-1c4b-4281-b951-d872f2087c98
-
hawk@chromium.org authored
Uncouple the cert verifier when disconnecting to avoid a callback after a SSLClientSocketMac object has bee freed. BUG=21832 TEST=none Review URL: http://codereview.chromium.org/206007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26236 0039d316-1c4b-4281-b951-d872f2087c98
-
mdm@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/205005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26235 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
We crash if we try to report geometry for a plugin that has been removed from the DOM. This CL makes changes to main.cpp to support the layout test, which corresponds to http://trac.webkit.org/changeset/48361. R=jam BUG=21841 TEST=covered by layout test Review URL: http://codereview.chromium.org/196126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26234 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
Reorder some of the zoom menus. Remove recent submenu. TEST=all the new names show up BUG=21228 Review URL: http://codereview.chromium.org/204021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26233 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
BUG=20707 TEST=tab text appears correctly in incognito. Review URL: http://codereview.chromium.org/196123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26232 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
If a result was found, restore focus to the tab contents. This allows for keyboard navigation using the find bar. Now with fix for valgrind failure. This CL reverts 26219, which in turn reverted 26214. BUG=http://crbug.com/12657 BUG=http://crbug.com/21374 TEST=See test case in bug 21374 Review URL: http://codereview.chromium.org/205010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26231 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
30+ minimally populated locales were added to our ICU data. As a result, GetAvailableLocale() used whenconstructing the UI language menu in Chrome list languages Chrome is not localized to. 1. Add IsPartiallyPopulatedLocale() to l10n_util (anonymous namespace) and skip those locales when constructing the locale list. 2. Add 'Hawaiian', 'Oromo' and 'Hausa' to the Accept-Language list. I'll add other languages to the trunk later. BUG=21119 (http://crbug.com/21119), 19329 ( http://crbug.com/19329 ) TEST=1. Launch Chrome and go to Options | "Advanced" | Languages & Fonts menu | Languages tab | Google Chrome language. The list of languages to choose from should contain only languages Chrome is localized to (40 + 1 + 8) and should not contain languages like Hawaian, Belarusian. 2. Accept-Language list should contain 3 new languages added (Hawaiian, Oromo and Hausa) Review URL: http://codereview.chromium.org/193027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26230 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
from the chrome sync client devchannel release branch. TBR=idana Review URL: http://codereview.chromium.org/196124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26229 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Fixing. TBR=jcampan BUG=None TEST=Build should work Review URL: http://codereview.chromium.org/204023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26228 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Review URL: http://codereview.chromium.org/201115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26226 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
BUG=None TEST=ran installer_util_unittests.exe Review URL: http://codereview.chromium.org/202002 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26225 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/19941jcampan@chromium.org authored
We would crash when an SSL error would happen on a page with no navigation entry. TEST=Run the test. BUG=http://crbug.com/19941 Review URL: http://codereview.chromium.org/196115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26224 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@google.com authored
TBR=huanr BUG=21862 TEST=none Review URL: http://codereview.chromium.org/194115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26223 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@google.com authored
BUG=21862 TEST=none Review URL: http://codereview.chromium.org/206010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26222 0039d316-1c4b-4281-b951-d872f2087c98
-
gwilson@google.com authored
Modifies the Firefox import behavior such that if we're in first run, the importer is headless, and we're only importing the home page, skip the Firefox lock. Otherwise, the process would silently wait for Firefox to close with no warnings. BUG=18709 TEST=set "import_home_page" : true, "skip_first_run_ui" : true in the master_preferences, and run without FirstRun. Import should not block. Review URL: http://codereview.chromium.org/174057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26221 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
See http://codereview.chromium.org/194109 for details. BUG=none TEST=none Review URL: http://codereview.chromium.org/196122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26220 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
Review URL: http://codereview.chromium.org/201116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26219 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=asargent BUG=20828 TEST=ExtensionApiTest.Tabs random failure Review URL: http://codereview.chromium.org/205009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26218 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Review URL: http://codereview.chromium.org/196106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26215 0039d316-1c4b-4281-b951-d872f2087c98
-