Review URL: http://codereview.chromium.org/5830004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=55907
TEST=None

Review URL: http://codereview.chromium.org/5890001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69252 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=523

Review URL: http://codereview.chromium.org/5716003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69246 0039d316-1c4b-4281-b951-d872f2087c98

If this one fails, I'm just reverting and calling it quits for tonight.

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/5844002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69245 0039d316-1c4b-4281-b951-d872f2087c98

Damn, missed a unittest.

BUG=28083
TEST=none

Review URL: http://codereview.chromium.org/3549010

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5885001

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/5887001

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5888001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=none

Review URL: http://codereview.chromium.org/3549010

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5885001

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/5887001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/5886001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:6990,chromium-os:9738
TEST=Click on the omnibox's star.  Press enter.  Check that the bookmark bubble closes.

Review URL: http://codereview.chromium.org/5254011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66817
TEST=ExtensionApiTest.DontCreateIncognitoProfile

Review URL: http://codereview.chromium.org/5742011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=none

Review URL: http://codereview.chromium.org/3549010

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5885001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69239 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach

BUG=66959
TEST=browser_tests
Review URL: http://codereview.chromium.org/5830003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=none

Review URL: http://codereview.chromium.org/3549010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69237 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

BUG=66957
TEST=browser_tests
Review URL: http://codereview.chromium.org/5883001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9650
TEST=manually open the dialog in Japanese and English (and preferably other langs)

Review URL: http://codereview.chromium.org/5880001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69235 0039d316-1c4b-4281-b951-d872f2087c98

Change MenuModel::IsLabelDynamicAt() to IsItemDynamicAt() to reflect its true
purpose.

Add SimpleMenuModel::GetIconForCommandId() to enable dynamic icons.

Update OSX menu_controller code to update the icon for dynamic menu items when
the menu is opened, to match the windows behavior.

BUG=66508
TEST=MenuControllerTest.Dynamic

Review URL: http://codereview.chromium.org/5697005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/5864002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unit_tests --gtest_filter=AutoFillMetricsTest.*

Review URL: http://codereview.chromium.org/5703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=it compiles

Review URL: http://codereview.chromium.org/5766004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69231 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly relevant when there are duplicate suggestions.

BUG=65133
TEST=none

Review URL: http://codereview.chromium.org/5851001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/5870001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=compiled locally and trybots

Review URL: http://codereview.chromium.org/5863001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69228 0039d316-1c4b-4281-b951-d872f2087c98

This change undoes most of http://src.chromium.org/viewvc/chrome?view=rev&revision=33953, since those changes weren't needed.
Review URL: http://codereview.chromium.org/5850001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69223 0039d316-1c4b-4281-b951-d872f2087c98

override as well.

TEST=not yet
BUG=none

Review URL: http://codereview.chromium.org/5591007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69222 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes some threading issues in PluginDataRemover. It also adds a static method to find out if removing plugin data is supported by an installed plugin, and a method to set the completion task while it is in the process of removing data.

BUG=58235
TEST=none

Review URL: http://codereview.chromium.org/5715001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28083
TEST=builds

Review URL: http://codereview.chromium.org/5852001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69220 0039d316-1c4b-4281-b951-d872f2087c98

The following extensions tests fail 100% of the time on all platforms:
InstallDifferentExtensions and StartWithDifferentExtensions.

Marking them as FAILS.

TBR=akalin@chromium.org
BUG=66925
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/5864001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69219 0039d316-1c4b-4281-b951-d872f2087c98

on startup after the machine has been running for a while. For the curious the crash occurs
in the tab preview code in Firefox which only executes on Windows 7 and executes even if
we disable tab preview.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5745008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69218 0039d316-1c4b-4281-b951-d872f2087c98

Test to see if this stops memory corruption crashes, will revert after a canary release.

BUG=65948
TEST=none

Review URL: http://codereview.chromium.org/5733003

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5805005

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5835001

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5828002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64664
TEST=none

Review URL: http://codereview.chromium.org/5859001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69216 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yurys
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=compiled locally and trybots

Review URL: http://codereview.chromium.org/5847001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69214 0039d316-1c4b-4281-b951-d872f2087c98

errors.

TBR=amit

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5845002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69213 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69212 0039d316-1c4b-4281-b951-d872f2087c98

Generalize tabswitcherview slightly so it doesn't rely on div naming to
obtain its styling.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5228004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69211 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62832
TEST=Copied zip to my machine, unzipped, loaded upacked extension.

Review URL: http://codereview.chromium.org/5675002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69210 0039d316-1c4b-4281-b951-d872f2087c98

Fixes build with latest gcc.

Patch from <asharif@chromium.org>
BUG=66770
TEST=trybots

Review URL: http://codereview.chromium.org/5787005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69209 0039d316-1c4b-4281-b951-d872f2087c98

Adjusting seccomp through the .gyp file is error-prone and confusing.
Instead, because all callers call SeccompSandboxEnabled(), if I
want to enable it for some build configuration I can adjust just that
function.

This change removes all the build-time seccomp configuration and
leaves it defaulted off.  It should have no change on whether seccomp
is enabled.

Review URL: http://codereview.chromium.org/5844001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69208 0039d316-1c4b-4281-b951-d872f2087c98

This makes it pass for all directories except third_party/qcms,
which unfortunately needs some careful figuring out of the license.

BUG=39240

Review URL: http://codereview.chromium.org/5830002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69207 0039d316-1c4b-4281-b951-d872f2087c98

Remove the 'restart required' alert when enabling the metrics reporting option, the alert is obsolete.

BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68919
Review URL: http://codereview.chromium.org/4778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69206 0039d316-1c4b-4281-b951-d872f2087c98