Suppress remoting_ Valgrind leaks; s/21ResourceMessageFilter/19RenderMessageFilter to fix the massive memory waterfall redness after r69076
TBR=glider
TEST=./tools/valgrind/waterfall.sh
BUG=66808
Review URL: http://codereview.chromium.org/5777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66808
TBR=glider
TEST=heapchecker bot should go greener
Review URL: http://codereview.chromium.org/5748007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69109 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69108 0039d316-1c4b-4281-b951-d872f2087c98

Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.

As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.

There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5682008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98

I tried to repro this bug and could not.  Seems to work.

BUG=58553,28083
TEST=python chrome/test/functional/cookies.py cookies.CookiesTest.testCookiesFile

Review URL: http://codereview.chromium.org/5721007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69106 0039d316-1c4b-4281-b951-d872f2087c98

- Shorten the signature for the crash in bug 66741.

TBR=thestig@chromium.org
BUG=66795
TEST=none
Review URL: http://codereview.chromium.org/5697009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69105 0039d316-1c4b-4281-b951-d872f2087c98

mode.

BUG=66118
TBR=none

Review URL: http://codereview.chromium.org/5707009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69104 0039d316-1c4b-4281-b951-d872f2087c98

where this dependency comes from.

TBR=amit
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5757004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5767004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69102 0039d316-1c4b-4281-b951-d872f2087c98

in ChromeFrame now takes in an interface NavigationConstraints which allows the delegateslike
the ActiveX, ActiveDocument and the NPAPI plugins to control the navigation decisions.

We no longer refer to the InternetSecurityManager interface which is IE only for performing
zone decisions in the ChromeFrame NPAPI plugin.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=66118

BUG=66118
TEST=Covered by additional CanNavigate unit tests.

Review URL: http://codereview.chromium.org/5698005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests

Review URL: http://codereview.chromium.org/5510006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69096 0039d316-1c4b-4281-b951-d872f2087c98

I don't see this on the ChromiumOS bots anymore.  I'm hoping it's either gone away, or it will turn a bot red quickly so I can analyze the problem.

BUG=62674
TEST=none

Review URL: http://codereview.chromium.org/5737006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69095 0039d316-1c4b-4281-b951-d872f2087c98

It used to be possible to navigate to a dnagerous file type to trigger its
download. Not anymore. Now all downloads where the user initiated it (by
navigating to a URL or clicking on a link) are not marked unsafe even for
unsafe filetypes.

Update the tests to trigger dangerous downloads by navigating to a file which
in turn triggers the dangerous files to download.

BUG=66081, 57875

Review URL: http://codereview.chromium.org/5781006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69093 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69091 0039d316-1c4b-4281-b951-d872f2087c98

Revert 69088 - Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager.

BUG=58576
TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes

Review URL: http://codereview.chromium.org/5322001

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/5682012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60243
TEST=none

Review URL: http://codereview.chromium.org/5633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69089 0039d316-1c4b-4281-b951-d872f2087c98

Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager.

BUG=58576
TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes

Review URL: http://codereview.chromium.org/5322001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69088 0039d316-1c4b-4281-b951-d872f2087c98

This change adds an explicit call to |hidePopups| when no username/password completion matches the contents of the username text field.

BUG=65985
TEST=Manual, according to bug steps.

Review URL: http://codereview.chromium.org/5726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5745006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69086 0039d316-1c4b-4281-b951-d872f2087c98

Split the layout tests run in the appcache ui tests into two groups, PHP dependent vs non-dependent. Also remove some tests that are racey from the layout tests run in these test cases.

BUG=54717
TEST=yes

Review URL: http://codereview.chromium.org/4858003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/5794003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98

According to,
http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKit/chromium/public/WebFrame.h
WebFrame::dispatchWillSendRequest is now deprecated.  Updating to use createAssociatedURLLoader() instead.

BUG=65806
TEST=media

Review URL: http://codereview.chromium.org/5515008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69083 0039d316-1c4b-4281-b951-d872f2087c98

This adds some plumbing for propagating the status and error code of a renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash.

Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done:

- Changed the name of DidProcessCrash to GetTerminationStatus.
- Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus.
- Improved process_util_unittest to actually test for crashing and terminated processes on all platforms.
- Added a new notification for renderers that were killed.
- Added error code information to crash notification.
- Added status and error code information to renderer IPC message for RenderViewGone.
- Added a UMA histogram count for number of renderer kills.

BUG=http://crosbug.com/8505
TEST=ran new unit test. Test passes on try servers.

Review URL: http://codereview.chromium.org/5172009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=No behavior change.

Review URL: http://codereview.chromium.org/5685008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66741
TEST=none
Review URL: http://codereview.chromium.org/5746006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69080 0039d316-1c4b-4281-b951-d872f2087c98

This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***.  TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows.

Consider PlatformThread::Join() to be blocking IO.

Marks PlatformThread::Join() as blocking IO using ThreadRestrictions.
Whitelists existing spots where we join on the UI/IO threads.

Also noteworthy is I allow blocking IO on shutdown.

BUG=65530, 66077, 66082
TEST=existing

Review URL: http://codereview.chromium.org/5750003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69079 0039d316-1c4b-4281-b951-d872f2087c98

  mac-release-10.5/intl1/times/t
  mac-release-10.5/intl2/times/t
  mac-release-10.5/startup/times/t
  mac-release-10.5/v8_benchmark/score/score
  mac-release-10.6/v8_benchmark/score/score
  vista-release-dual-core/v8_benchmark/score/score
  xp-release-dual-core/intl1/times/t
  xp-release-dual-core/intl2/times/t
  xp-release-dual-core/morejs/times/t
  xp-release-dual-core/v8_benchmark/score/score

BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/5781007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69078 0039d316-1c4b-4281-b951-d872f2087c98

I don't think eliminating _all_ objc from base is the right answer -- the remaining objc has to move out of the static libbase. But if it's easy to have fewer objc to move, that's good.

BUG=46929
TEST=One fewer duplicate symbol is reported when loading the pdf plugin.

Review URL: http://codereview.chromium.org/5716007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69077 0039d316-1c4b-4281-b951-d872f2087c98

Rename ResourceMessageFilter to RenderMessageFilter, since that's what it actually is.  I will add a ResourceMessageFilter just for resource IPCs in a future change.
Review URL: http://codereview.chromium.org/5701004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69076 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=compiles

Review URL: http://codereview.chromium.org/5712003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69074 0039d316-1c4b-4281-b951-d872f2087c98

Fix extension packer command-line code for Mac. Instead of blocking in a janky way by running the message loop, I added an option to run the extension packer job synchronously.

One thing to note as it pertains to the bug report is that the path must be fully qualified. ~/ for home directories doesn't work for me.

BUG=65645
TEST=none

Review URL: http://codereview.chromium.org/5703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=safe_browsing_service_browsertest
Review URL: http://codereview.chromium.org/5544008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Make sure 'dry run' jobs does not get printed.

Review URL: http://codereview.chromium.org/5736004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69071 0039d316-1c4b-4281-b951-d872f2087c98

We receive multiple NavigateComplete notifications at times.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69070 0039d316-1c4b-4281-b951-d872f2087c98

By using a command to fetch trybot output, we can pipe the result
through a sed script that trims down the Mac output.  This makes
the output small enough so that compilation-mode can handle it.

While I'm at it, I can use file:/// URLs to unify more of the
"real" and "test" code paths.

Review URL: http://codereview.chromium.org/5737005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69069 0039d316-1c4b-4281-b951-d872f2087c98

Bookmark buttons would get stuck with a hover state if they were obscured while the mouse was inside the button.

The problem was that the hover state only tracked the mouse entered and exited events. Unfortunately if the button is obscured because it has been removed from the window then a mouse exited event is not sent.

Fix was to also update the hover state in the -[NSCell resetCursorRect:inView:] event.

This change also improves the mouse tracking code by checking if the mouse is already in over the button.

BUG=27073
TEST=Changed tabs with the mouse over a bookmark button. Verified that the hover effect was no longer there after closing the new tab. Did a similar test by entering full screen. Verified that the hover effect was no longer there.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69068 0039d316-1c4b-4281-b951-d872f2087c98

The reason of the issue is ibus intercepts all key events and does not
forward them to chrome at all, while webkit relies on key events to
reset one of its internal flag. This CL just fakes key down/up events if
the input method intercepts all key events.

BUG=45478
TEST=see bug report.

Review URL: http://codereview.chromium.org/5787004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69067 0039d316-1c4b-4281-b951-d872f2087c98

...by inspecting if the module with the crash has the topmost handler
in the SEH chain.  If that's the case then the exception will very
likely be handled. This covers the case of IsBadReadPtr adn family
without any special code. It also lets us address IsValidInterface,
an internal helper in urlmon.

BUG=64348
TEST=covered by existing unit tests

Review URL: http://codereview.chromium.org/5622006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59282
TEST=none

Review URL: http://codereview.chromium.org/5810002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69065 0039d316-1c4b-4281-b951-d872f2087c98