- Nov 06, 2024
-
-
Chrome Release Bot (LUCI) authored
Change-Id: Ib007878301b7bc18f7966e85ece0cb87e4a6330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000791 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6823@{#2} Cr-Branched-From: 1a4b691a-refs/heads/main@{#1378986}
-
Chrome Release Bot (LUCI) authored
Change-Id: I4fd065c822c2ec9ce36699aeff4a5b367a6f9d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999112 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6823@{#1} Cr-Branched-From: 1a4b691a-refs/heads/main@{#1378986}
-
Sylvain Defresne authored
Decouple the runner from the queue, allowing to have multiple runners (one per ProfileState and one for AppState) while the tasks are still sequenced serially in the same queue. Expose a DeferredInitializationRunner from the AppState and use it when scheduling tasks from the MainController (instead of a singleton instance). Move registration of the ReadlingListDownloadService from the StartupTaks to MainController (though they will eventually be moved to ProfileController). Bug: 333863468 Change-Id: I3aef15913b2eb6f7eea5263b9a97e02ee43570f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993853 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Aliona Dangla <alionadangla@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378986}
-
Abigail Katcoff authored
Add new feature to experiment with using a v8 flag, --no-wasm-lazy-compilation, in our worklets, with the hope of improving our latency. We usually have the code downloaded sigificantly before we are ready to run the script, so it's better to compile the wasm in advance non-lazily. Bug: 376312705 Change-Id: I4c7ec95c2506cef5a0d27638a1aa79abcaa270db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974140 Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org> Reviewed-by:
Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/main@{#1378985}
-
Michael Slutskii authored
The corresponding logic was moved to gaia_screen_handler, so this code currently doesn't do anything. Bug: 377281580 Change-Id: I171583e8fd15150ff2cc70c296e6b84e58975e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5987875 Reviewed-by:
Andrey Davydov <andreydav@google.com> Commit-Queue: Michael Slutskii <slutskii@google.com> Cr-Commit-Position: refs/heads/main@{#1378984}
-
Danil Somsikov authored
Bug: 376625003 Change-Id: I7fd532c28dc9017380fb364c4af0bbdc7ea2549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000132 Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/dbc0c5f711d9..13d32327478a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com,samarchehade@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: samarchehade@google.com No-Try: true Change-Id: I833968d8418327883075ebd3962c0d6e576c2780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000023 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378982}
-
Valerie Young authored
When the flag is on, and the NSAccessibilityAttribute is replaced with a method in the method-based API, calling accessibilityAttributeValue should return in a no-op. Bug: 363275809 Change-Id: I459a6f0dbc0deba673435c3781a98466ce2c9f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939277 Commit-Queue: Valerie Young <spectranaut@igalia.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378981}
-
Amit Dror authored
The is required for team IDs that start with a number. Bug: None Change-Id: Iacde90e36cdb59ada8194bb28c9b6d4f129d343d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993493 Reviewed-by:
Mark Rowe <markrowe@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378980}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2cc99f154455..8702008d4f50 2024-11-06 jleconte@webrtc.org Add llvm-libc dependency, now required for libc++. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I51760282d21c7f877158824c846ec2e0e45921a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000038 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378979}
-
Ryan Sultanem authored
Modifies existing histogram to record an enum for each entry point, instead of always true. Histogram affected: `Sync.BatchUpload.Opened`. The histogram was only recorded at most on Canary, making it ok to modify the way it is recorded. Bug: b:375351323 Change-Id: I515d9869b157c98ca5aea678506cb3a8af72ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973104 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ryan Sultanem <rsult@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/main@{#1378978}
-
Thomas Nguyen authored
This is a reland of commit 1924a27a Changes compared to original CL: - A null check for the frame (when we moved stuff from AttachLayout to InsertedInto) - Remove conditions CHECKs when calling UnregisterClient Original change's description: > [PEPC] Snapshot permission statuses at commit navigation > > When <permission> element is added to the DOM, we'll use IPC to check > the permission status and it'll update when the IPC callback is > triggered. This might cause a flicker if the status changes from ASK > to GRANTED. > > We propose to snapshot permission statuses and cache the statuses at > the execution context, outlined in: https://docs.google.com/document/d/1pfuiJ7BIdX0dxMzboYIOvPV1mFKQ3HE_11VQNeBJSCc/edit?resourcekey=0-9el74tCe5opJXh3CIPyPGA&tab=t.0#heading=h.8zmwced28dbp > > Bug: 368238224 > Change-Id: Ib319301d0b9bedb07502a09b4f030d3e40844ea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905369 > Reviewed-by:
Thomas Nguyen <tungnh@chromium.org> > Commit-Queue: Thomas Nguyen <tungnh@chromium.org> > Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> > Reviewed-by:
Daniel Cheng <dcheng@chromium.org> > Reviewed-by:
Francois Pierre Doray <fdoray@chromium.org> > Auto-Submit: Thomas Nguyen <tungnh@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1372969} Bug: 368238224 Change-Id: Idb09359fa342393a6fa0956d057955c45e68e723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972695 Reviewed-by:
Francois Pierre Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Nguyen <tungnh@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378977}
-
amarjotgill authored
Plumbing data for a port and scheme mismatch and blocking when they occur, this will only occur when kEnableSchemeBoundCookies or kEnablePortBoundCookies are enabled. Bug: 375571828 Change-Id: I3d12d9c2032906981797a7ef603b080988ae21f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5989011 Reviewed-by:
Steven Bingler <bingler@chromium.org> Commit-Queue: Amarjot Gill <amarjotgill@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378976}
-
Florian Leimgruber authored
- Inlines ApplyRationalizationsToFieldAndLog() and RationalizeAddressLineFields() into RationalizeRepeatedFields() - Renames RationalizeRepeatedFields() to RationalizeRepeatedStreetAddressFields() and makes it private. - Calls RationalizeRepeatedStreetAddressFields() as part of RationalizeFieldTypePredictions(). - Changes the test names accordingly. Bug: 320965828, 40100455 Change-Id: I57c5d12a199a099b7d7a9071b44aafb467e55b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993438 Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Reviewed-by:
Jihad Hanna <jihadghanna@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378975}
-
vincb authored
Change-Id: Ia4cd79ffcc02b7bda7459ce88b47580aeb58881d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994774 Reviewed-by:
Noémie St-Onge <noemies@google.com> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/main@{#1378974}
-
Marc Treib authored
PasswordManagerViewController was observing `identityListChanged` from ChromeAccountManagerServiceObserver, for the purpose (per the CL that originally introduced it, crrev.com/c/1856078) of reloading itself on signout. First, this doesn't necessarily work, since a signout doesn't always come with a change to the identity list. Second, it'll cause a reload in many cases where it's not necessary. This CL changes PasswordManagerViewController to observe IdentityManager instead, specifically `onPrimaryAccountChanged` which matches the intention much better. Bug: 377467350 Change-Id: I0010a6a519e8698ca6ecfb712eec9dce414a202d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999570 Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378973}
-
Julia Sobiech authored
Change-Id: I729588bdbe8d097b657cb6804cdc79d3e515d16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999351 Reviewed-by:
Florian Leimgruber <fleimgruber@google.com> Reviewed-by:
Jihad Hanna <jihadghanna@google.com> Commit-Queue: Julia Sobiech <jsobiech@google.com> Cr-Commit-Position: refs/heads/main@{#1378972}
-
Keishi Hattori authored
This reverts commit d598953e. Reason for revert: Caused failure. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/20867/overview Original change's description: > [FaceGaze] Persist strings for held macros in bubble UI > > * Persist strings for macros that are held. > * Due to complexities with tracking state, if new actions are triggered > while the macro is held, the strings for the new actions will populate > the bubble UI immediately, but not include the held macros. When the > bubble UI resets after a timeout, the held macros will populate the > bubble UI again at that time. > * Add tests. > > Fixed: 375235384 > Change-Id: I22dcd68229dc1da033668051ac615ff09f378f0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5985158 > Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: Amanda Lin Dietz <aldietz@google.com> > Cr-Commit-Position: refs/heads/main@{#1378443} Change-Id: Ic16118875d967b8e25d54ef83e6ae98d4dcd9579 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998051 Commit-Queue: Ravjit Uppal <ravjit@chromium.org> Owners-Override: Keishi Hattori <keishi@chromium.org> Auto-Submit: Keishi Hattori <keishi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378971}
-
Florian Leimgruber authored
Currently, repeated field is performed when the server response arrives [1], but not as part of DetermineHeuristicTypes(). As discussed offline, let's perform repeated field rationalisation in both cases. [1] https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_encoding.cc;l=836;drc=89f7acaf322ac2528ef7341f9a39473ae8599ce0 Bug: 320965828 Change-Id: I59b946a4e74330b0abb76da3e7ccf9dacb23ebdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5992803 Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378970}
-
Alex Rudenko authored
Fixed: 40794449 Change-Id: Ie1cda65b338442730c693cdb730eac946e26a9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999455 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/9a1e9021ceb7..c182c0491684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/optimization-guide-chromium Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I05eadfa22d8c349f046ea7e232b5b01e49d5e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000213 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378968}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-main-1730872697-c236a497a9032180e63dd16c17f84f4041c25477-5f89eabf.profdata to chrome-linux-main-1730894247-3b5b7bdc04fdf6bf3accc752b8e35b1ccab97b05-7d07d388.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fb68e04a79386dab462ae6b1a90fc91780dd5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000035 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378967}
-
Daniil Sakhapov authored
Activation of scroll marker should call scroll into view API on scroll marker, which was done for clicking on scroll marker, but not for activation via clicking on scroll button. This CL also fixes which style is taken to compute scroll into view params, since it was ultimate originating element (UOE), but should be just parent element: UOE for regular scroll marker and ::column for column scroll marker. Fixed: 376864061 Change-Id: Ib42684aecc2a8d7d54ce686dfa2ab6d2bd764851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000151 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378966}
-
Claudio DeSouza authored
This CL adds fixed sizes to `const string` mojom fields, making them `contexpr`-friendly, as the size gets encoded into the data type. Bug: n/a Change-Id: Id3ea991cd737bf1e3bdd92e204cbb305a8c38084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988112 Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378965}
-
Piotr Wrótniak authored
Adds removing: - references to sources in observer during sources destruction explicitly, - references to observer in sources during observer destruction using scoped observation. Previously this logic was missing potentially leading to dangling references in outliving sources/observer depending on the order of destruction. Bug: 40258491 Change-Id: I650fe6aa6b12c53d89be0e4e63521d9a9849ef06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5937909 Auto-Submit: Piotr Wrótniak <piotrwrotniak@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Keitel <jkeitel@google.com> Commit-Queue: Piotr Wrótniak <piotrwrotniak@google.com> Cr-Commit-Position: refs/heads/main@{#1378964}
-
Po-Heng Chen authored
observeCpuUsagePromise is used in observeMemoryUsage related methods. Correct them to observerMemoryUsagePromise. --gtest_filter="DiagnosticsApp*" Bug: 377630459 Test: browser_tests -ozone-platform=headless Change-Id: Icbc6abfa631dbe17e2c0b5cdafa340715529c26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999130 Reviewed-by:
Denny Huang <dennyh@google.com> Commit-Queue: Po-Heng Chen <pohengchen@google.com> Reviewed-by:
Byron Lee <byronlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378963}
-
chromium-autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1730886144-3f2cb959a6fe8f70962c3245ed418161ac14724a-4484d305.profdata to chrome-android64-main-1730887512-a0c833c0469fcea5c8c39623a8ef9850f8613328-c086b469.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e99ea4c16346a89a84592a9ba6ba77018aa027a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000431 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378962}
-
Daniel Vogelheim authored
This implements the data members and associated functions of SanitizerConfig. It does not (yet) implement the actual sanitization logic, or handling of defaults. Bug: 356601280 Change-Id: Iba9f1f053a74f1420e60551b734c6321e4309596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981094 Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378961}
-
Rune Lillesveen authored
Change-Id: Ic30154dd0c68f9c5c77feb728512503b3c0b5bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5993511 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Noam Rosenthal <nrosenthal@chromium.org> Reviewed-by:
Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/22a263775eac..92891c4f76b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC bwwilliams@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I2a1d43125c0e94540d7e42233319bc27f3ff8fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000018 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378959}
-
Minoru Chikamune authored
This CL reverts the following changes because this MiracleParameter experiment didn't show any improvements. https://chromium-review.googlesource.com/c/chromium/src/+/4840758 https://chromium-review.googlesource.com/c/chromium/src/+/4896068 Bug: 40279826 Change-Id: I5c5d1269a35cda4132942d2c6da46e7af9e205ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5997951 Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82175b411c80..b4df8dda7ffc 2024-11-06 lukasza@chromium.org [rust png] Fix when `setAlphaAndRequiredFrame` is called. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:356922876 Tbr: kjlubick@google.com Change-Id: Iaffb65201953fd824d967b8769a566e1de52b849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000014 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378957}
-
Anders Hartvoll Ruud authored
The selectors within the @scope prelude were previously unforgiving (like within :is()), but this was changed in Issue 10042 [1]. Being forgiving means a rule like "@scope (.a, :unknown-thing)" would behave like "@scope (.a)" (the invalid parts are just silently ignored), whereas unforgiving behavior would consider it a parse error. [1] https://github.com/w3c/csswg-drafts/issues/10042 Fixed: 346555843, 343794754 Change-Id: I017c098c1406bcc0df62690038d16879c1e8c110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999993 Reviewed-by:
Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378956}
-
Rune Lillesveen authored
Change-Id: Ie5e475520145b62e1d9273d56c02c74e1435ebfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991431 Reviewed-by:
Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378955}
-
chromium-autoroll authored
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1730872697-789f4b430ff843fb4977d6601c251b158e010b92-5f89eabf.profdata to chrome-win-arm64-main-1730894247-f46fac526dc712e5398776b8c0489643d74f58b0-7d07d388.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I468522617db9f81a8dd78b974fb3b6d38f6ebf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000215 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378954}
-
Reema A authored
Bug: 369865059 Change-Id: I417b483afb1b217c0d42b02a5a6b3c4f553ef7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5983389 Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Reema A <reemaa@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378953}
-
Artem Sumaneev authored
Project number has a specification of int64 per go/elysium/project_ids#summary. The field is not used yet, and the type can be safely changed. Bug: b:375145004 Change-Id: Id712c156e8f6b6875d234dfbbf7e38694dd5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000331 Commit-Queue: Artem Sumaneev <asumaneev@google.com> Reviewed-by:
Victor Gabriel Savu <vsavu@google.com> Auto-Submit: Artem Sumaneev <asumaneev@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378952}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc2edfd1128a..d399841a9226 2024-11-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1495532f997f to 76855a9baecc (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: yuxinhu@google.com Change-Id: I3c2a8d089c1faeda25a2d46d0a0ed477b5f12644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000211 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1378951}
-
Awad Osman authored
Our UX and PM want the password leak toggle to be the first option under the advanced section on the chrome://settings/security page. Screenshot(Before):https://crbug.com/370770920#comment3 Screenshot(After):https://crbug.com/370770920#comment9 Bug: 370770920 Change-Id: Id5dab3089c2db2fe8a1159fb971875f8e91ef27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998450 Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Awad Osman <awado@google.com> Cr-Commit-Position: refs/heads/main@{#1378950}
-
Morten Stenshorne authored
Enabled by default since M106. Bug: 356235206 Change-Id: Ie26282921d5b5e62e47851dc24e4f80ea41d0707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999732 Reviewed-by:
Ryan Tarpine <rtarpine@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378949}
-