- Aug 05, 2019
-
-
Olivier Crête authored
Uses a wrap file to download a prebuilt OpenSSL from our git as a subproject. Builds for both amd64 & x86
-
It crashes on Windows
-
- Aug 02, 2019
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
This makes it work with Windows MSVC builds of OpenSSL which don't include a pkg-config file.
-
For now it uses the gstreamer docker image and shared runner, based on windows server 1607. The runner will migrate to windows 1807 soonish hopefully. This commit also adds a glib wrap file needed to build libnice.
-
Olivier Crête authored
Shell scripts don't work well on Windows and Python doesn't work with valgrind.
-
Olivier Crête authored
-
Fabrice Bellet authored
-
- Aug 01, 2019
-
-
Olivier Crête authored
-
- Jul 31, 2019
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
It's most likely caused by a retransmission received after the initial request already had a reply.
-
Olivier Crête authored
The child now calls into the parent..
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
- Jul 30, 2019
-
-
Fabrice Bellet authored
When evaluating the stopping criterion, failed pairs from other streams having the "use_candidate_on_next_check" flag set should be ignored. This should normally not happen, because a pair selected for nomination has no reason to fail when being rechecked, since it previously worked... but it may happen with Skype for Business, when libnice selects a tcp pair for component 1, the peer seems to have no interest in the second component and lets it fail in the middle of the conncheck.
-
Fabrice Bellet authored
This patch doesn't change the logic of the selection of the pair for nomination, it makes the code a bit more simple to read.
-
- Jul 29, 2019
-
-
Fabrice Bellet authored
A previous commit c1fb6f28 introduced a regression in the way the foundation of a selected pair is updated and signaled, when the foundation of its remote candidate changes. The previous comparison was made on *always* identical strings, so the update of the selected pair was *never* signaled.
-
Fabrice Bellet authored
We may not have received remote candidates yet, but we may have discovered remote candidates from the early incoming checks. Only having stream credentials is required to react to these checks.
-
- Jul 28, 2019
-
-
Olivier Crête authored
The IPv6 struct sockaddr variant is bigger than the IPv4 one, so use the storage struct to ensure that the size is big enough.
-
- Jul 22, 2019
-
-
Jakub Adam authored
If the initial attempt at sending discovery message returns a socket error, don't start the retransmit timer and immediately mark such discovery item as done. This is to quickly eliminate clearly non-functioning items from the discovery process. Particularly improves times to finish discovery on Windows, where sending data from a link-local (169.254.0.0/16) IP to a destination not on the same subnet leads to "A socket operation was attempted to an unreachable network" error. Pointless retransmissions on those sockets prolonged discovery in the order of seconds.
-
- Jul 19, 2019
-
-
Jakub Adam authored
-
Fabrice Bellet authored
The nomination of a pair having such a local candidate breaks SfB when the libnice agent is behind a nat that does not do port mapping randomization. In that case a server reflexive local candidate usually lead to a nominated pair. The guess made here from observing this behavior is that, it is valid to discover and signal these local server reflexive candidates to our peer, but they should be removed from our local candidates list thereafter, so they do not contribute to build a valid and *even worse* a nominated pair with the type server-reflexive. They do not appear in the conncheck list per design anyway. Instead, the same candidate is discovered again later during the conncheck, with a peer-reflexive type this time, and with that type, it just works. Closes #90
-
- Jul 12, 2019
-
-
Fabrice Bellet authored
In some rare cases, the same address and port number may match two remotes candidates, a tcp and an udp one, and lead to buggy pair construction with incompatible transport. This supplementary check prevents this problem. The matching test is not aimed to be exhaustive but just a way to discard obviously broken associations, and fallback to accept everything else (because socket type has a great diversity, with socket types based on other sockets types). It should fix #81, where such bogus transport association has been reported (tcp-pass:udp).
-
Jakub Adam authored
Once an interface got ignored, ALL interfaces coming after it were dropped too.
-
Jakub Adam authored
Fixes MSVC build.
-
Jakub Adam authored
Since g_parse_debug_string() was looking only at the first 4 items in GDebugKey arrays, "libnice-verbose" couldn't get activated.
-
- Jul 11, 2019
-
-
Fabrice Bellet authored
-
Fabrice Bellet authored
We support turn-tcp in oc2007 compatibility only and when the host candidate transport is compatible, ie when reliable_tcp is true.
-
Fabrice Bellet authored
When receiving an stun packet on a socket, and looking for the matching local candidate, normally it doesn't make a difference to test the address or the base address. Because a pair cannot have a local candidate of type srv-rflx, where there would be a difference, the local candidate obtained will be part of a pair of the conncheck list. Except for the case of a pairs with tcp-act local candidate, where the addr has a port number of zero (tcp-act socket before connect), and the socket of the stun packet has a non-null port number (tcp-act socket after connect), corresponding to the base address of another peer-reflexive tcp-act local candidate, previously discoverd. The selection of the local candidate concerned by an inbound stun request happens when early incoming checks are processed, and when inbound stun packets are normally received during the conncheck. This commit complete commit e6a19418 (for early incoming checks) in the normal inbound stun packets code path, where is similar modification is needed.
-
Fabrice Bellet authored
This patch rewrites the comment surrounding this code snippet, to make it clear, that this pair selection is not specific to the tcp transport.
-