For BWSI (incognito) mode, we want to make sure that we don't leak
private information between sessions, so we need to have chrome write
log output to the tmpfs created for that mode.

Also, the chrome log in "logged in" mode should reside in the "log"
subdir instead of in the user data dir.

BUG=http://crosbug.com/6908
TEST=Ran on device in incognito and regular modes, and watched where
log output ended up.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64638

Review URL: http://codereview.chromium.org/4194005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64826 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains following major changes:
1. Uses GtkLabel instead of GtkTextView for displaying instant
suggestion.
2. Attaches the instant view to a child anchor in the text view.
3. Treats preedit string as part of user input, so that autocomplete match can take effect with uncommitted preedit string.

BUG=27547
TEST=Instant suggestion should work as normal. And preedit string should trigger autocomplete match and work with Instant suggestion.

Review URL: http://codereview.chromium.org/4202005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64825 0039d316-1c4b-4281-b951-d872f2087c98

Allow an HTML dialog to suppress the title bar in a Chromium OS bubble window.
For the Cloud Print dialog, remember the last size requested by the contents.

BUG=chromium-os:8494
TEST=none

Review URL: http://codereview.chromium.org/4110010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64824 0039d316-1c4b-4281-b951-d872f2087c98

Two fixes:
1. Wait for the software backing store to paint before hiding the gpu view (this was http://codereview.chromium.org/4030005 , now changed to address the review feedback)
2. Disable screen updates until window flush when hiding the gpu view

BUG=57645
TEST=Mouse over sticky notes at http://nettuts.s3.amazonaws.com/771_sticky/step5.html , shouldn't flicker. Zoom in and out on maps.google.com, shouldn't flicker.

Review URL: http://codereview.chromium.org/4148004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28174
TEST=trybots

Review URL: http://codereview.chromium.org/4130012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4262005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64819 0039d316-1c4b-4281-b951-d872f2087c98

(Landing http://http://codereview.chromium.org/4167011 for hclam)

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/4336001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61627
TEST=none

Review URL: http://codereview.chromium.org/4244005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64817 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that CertStore::StoreCert never returns a cert_id of 0.

Original review URL: http://codereview.chromium.org/4181006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64816 0039d316-1c4b-4281-b951-d872f2087c98

Check for TLS 1.1 and TLS 1.2 (not yet supported)
version numbers to be future-proof.

Avoid a null pointer dereference when SSL client
authentication is used with SSL 2.0.  This will
be removed when we remove SSL 2.0 support.

Define the SSL_CONNECTION_VERSION_xxx enum constants
separately so we can assert their values are in range
at compile time.

R=eroman
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4211006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64814 0039d316-1c4b-4281-b951-d872f2087c98

load.  The performance optimization of doing EV verification
for only main frames is incorrect with HTTP keep-alive connections.

R=eroman
BUG=41267
TEST=Visit https://www.paypal.com/.  Hit the Reload button
repeatedly.  The EV status should not disappear.
Review URL: http://codereview.chromium.org/3938001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64813 0039d316-1c4b-4281-b951-d872f2087c98

If an extension uses "spanning" mode, the context menu items are shared
between profiles. If an extension uses "split" mode, the items are separate
per profile. In either case, they only appear in incognito if the extension is
enabled in incognito.

Also fixed a minor bug, so that tabs.create now can open extension URLs in
incognito if the extension uses split mode.

BUG=61147
TEST=see bug for repro steps; context menu items should work in incognito mode

Review URL: http://codereview.chromium.org/4090011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64812 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61636
TEST=None. Absolutely none.

Review URL: http://codereview.chromium.org/4231004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8193
TEST=manual
Review URL: http://codereview.chromium.org/4237001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64808 0039d316-1c4b-4281-b951-d872f2087c98

Minimum change to remove the title and get the initial dialog size correct.
Still has gobs of whitespace at the top.

BUG=chromium-os:8494
TEST=none

Review URL: http://codereview.chromium.org/4146015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/4261001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64806 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky
BUG=61592
TEST=

Review URL: http://codereview.chromium.org/4321002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8400
TEST=make sure cellular device can be activated from UI

Review URL: http://codereview.chromium.org/4311002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Would not run correctly on Windows.
TEST=None.

Review URL: http://codereview.chromium.org/4335001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64803 0039d316-1c4b-4281-b951-d872f2087c98

Updating test expectation for security/block-test-no-port.html since it seems to fail on the Mac too.

BUG=31342
TEST=NONE

Review URL: http://codereview.chromium.org/4262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64802 0039d316-1c4b-4281-b951-d872f2087c98

BUG=28153
TEST=compiles locally and trybots

Review URL: http://codereview.chromium.org/4282003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64801 0039d316-1c4b-4281-b951-d872f2087c98

Patch of http://codereview.chromium.org/4106015/show

BUG=chromium-os:8440
TEST=Ensure that there is no crash after taking picture. Try several times, as this is timing related.

Review URL: http://codereview.chromium.org/4228002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64800 0039d316-1c4b-4281-b951-d872f2087c98

This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.

BUG=28083
TEST=None

Review URL: http://codereview.chromium.org/4291001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=All tests should pass. Autocomplete/autofill should still work.

Review URL: http://codereview.chromium.org/4231001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64797 0039d316-1c4b-4281-b951-d872f2087c98

Looks like the pattern match doesn't work for some reason: http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20(valgrind)/builds/259/steps/memory%20test:%20unit/logs/stdio

BUG=61424
TEST=None
TBR=rsesek

Review URL: http://codereview.chromium.org/4276003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64795 0039d316-1c4b-4281-b951-d872f2087c98

Another speculative fix for the crash in the bug.

BUG=58042
TEST=sync integration tests

Review URL: http://codereview.chromium.org/4275001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64793 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=base_unittests --gtest_filter=*StringToInt*

Review URL: http://codereview.chromium.org/4129012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61581,chromium-os:7037
TEST=ExtensionsServiceTest.UpdatePendingExternalCrxWinsOverSync

Review URL: http://codereview.chromium.org/4147007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39963
TEST=None
TBR=rafaelw

Review URL: http://codereview.chromium.org/4241003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64787 0039d316-1c4b-4281-b951-d872f2087c98

which is generally caused by a firewall.

Also removes the title strings for proxy and disconnected
errors, replacing them with pre-existing generic ones, and
sorting them by their new title.  This avoids a debug
assertion caused by the fact neither title includes the url
of the original page.  Not much of titles are seen anyways,
so not worth the effort of a workaround.

BUG=57108
TEST=manual

Review URL: http://codereview.chromium.org/4182012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:8517
TEST=Accelerators/TestBasic in desktopui_BrowserTest will not fail

Review URL: http://codereview.chromium.org/4271001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60318
TEST=See bug (enable html5 video on youtube, watch a video, click omnibox, click youtube search box. It should focus. Same on grooveshark: the search box should focus when clicked after clicking the omnibox)

Review URL: http://codereview.chromium.org/4287002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64784 0039d316-1c4b-4281-b951-d872f2087c98

I adjusted the code so tha there was no chance
for the pending response count to get to zero
until all the increments had been applied, and
all the rendereres had been notified.  Without
this change, there was a chance that the tally
would hit zero prematurely, triggering a
a premature completion.

I went through the code clarifying where
a lock was needed, and where it wasn't.
In all cases, we now either take a lock, or
assert we're consistently on a single
thread (meaning we don't need a lock).

r=davemoore
Review URL: http://codereview.chromium.org/4193008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64781 0039d316-1c4b-4281-b951-d872f2087c98

Marking a bunch of login prompt tests as faily on windows due to them relying on a flaky test server:

LoginPromptTest.CancelRedundantAuths
LoginPromptTest.SupplyRedundantAuths
LoginPromptTest.TestBasicAuth
LoginPromptTest.TestCancelAuth
LoginPromptTest.TestDigestAuth
LoginPromptTest.TestTwoAuths


BUG=60937
TEST=None


Review URL: http://codereview.chromium.org/4322001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64780 0039d316-1c4b-4281-b951-d872f2087c98

Marking ErrorPageTest.IFrame404 as flaky on Windows builders, probably related to the test server bugging out occasionally.

BUG=60937
TEST=NONE.


Review URL: http://codereview.chromium.org/4251003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64778 0039d316-1c4b-4281-b951-d872f2087c98

[  FAILED  ] SessionHistoryTest.BasicBackForward
[  FAILED  ] SessionHistoryTest.FrameBackForward
[  FAILED  ] SessionHistoryTest.FrameFormBackForward
[  FAILED  ] SessionHistoryTest.FragmentBackForward
[  FAILED  ] SessionHistoryTest.LocationChangeInSubframe

BUG=61619
TEST=None



Review URL: http://codereview.chromium.org/4298002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64776 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64775 0039d316-1c4b-4281-b951-d872f2087c98

Original CL:
Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put
its guts into Extension.

BUG=56558
TEST=no functional change

Review URL: http://codereview.chromium.org/4200005

Review URL: http://codereview.chromium.org/4277002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64767 0039d316-1c4b-4281-b951-d872f2087c98

to the trybot.

TBR=erikkay@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64766 0039d316-1c4b-4281-b951-d872f2087c98

Moved constants to anonymous namespace.

BUG=chromium-os:5763
TEST=none. no functional/visual change.

Review URL: http://codereview.chromium.org/4252002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64765 0039d316-1c4b-4281-b951-d872f2087c98