failure modes on different platforms.

BUG=67919
TEST=none
TBR=thakis

Review URL: http://codereview.chromium.org/5961010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70119 0039d316-1c4b-4281-b951-d872f2087c98

- enable searching for sub-pages and overlays.
- search-related performance improvements.

BUG=59267
TEST=Verify search find results in sub-pages.  Control(button) highlighting TBD.
Review URL: http://codereview.chromium.org/5992004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59980
TEST=Install extension with background page, see badge.

Review URL: http://codereview.chromium.org/6051007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70117 0039d316-1c4b-4281-b951-d872f2087c98

Originally I was going to create a single "system" URLRequestContext.  I realized that was wrong, I need one for proxy script fetching that uses a direct ProxyService.  This way, we don't have the circular dependencies for URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(A).  Instead, we have URLRequestContext(A)=>ProxyService=>ProxyScriptFetcherImpl=>URLRequestContext(special one for proxy).

This also exposes some setters in URLRequestContext that were in ChromeURLRequestContext.  I guess this makes URLRequestContext a bit more "dangerous" since it could be mutated during runtime, but really we should probably pass around a const URLRequestContext within the network stack.  I've filed http://crbug.com/67597 to track this.

BUG=67232
TEST=none

Review URL: http://codereview.chromium.org/5961005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests

Review URL: http://codereview.chromium.org/6003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59980
TEST=enable extension with background page, see wrench menu badge

Review URL: http://codereview.chromium.org/6037010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67932

Review URL: http://codereview.chromium.org/6020011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70113 0039d316-1c4b-4281-b951-d872f2087c98

TODO(evan): remove this in a few months.

Review URL: http://codereview.chromium.org/6096001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70112 0039d316-1c4b-4281-b951-d872f2087c98

with cmp and skerner to clear up assertion failure in UI tests on
Vista apparently caused by
https://bugs.webkit.org/show_bug.cgi?id=51186 .

BUG=none
TEST=none
TBR=andreip

Review URL: http://codereview.chromium.org/5962011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70111 0039d316-1c4b-4281-b951-d872f2087c98

I always have trouble finding this tool because of its weird name
and place.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70110 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6038003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70109 0039d316-1c4b-4281-b951-d872f2087c98

  /session/:sessionId/timeouts/implicit_wait
  /session/:sessionId/element
  /session/:sessionId/elements
  /session/:sessionId/element/:id/element
  /session/:sessionId/element/:id/elements

BUG=none
TEST=webdriver_remote_tests.py

Review URL: http://codereview.chromium.org/3643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70107 0039d316-1c4b-4281-b951-d872f2087c98

Clean up Automation and Chrome Frame IPC code.-only use routed messages when needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile.
Review URL: http://codereview.chromium.org/5998006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98

When an extension in being unloaded, some listeners want to know if it's 
because the extension is being updated to a newer version, or disabled. This
changes the details sent to include a reason.

Also this removes the EXTENSION_UNLOADED_DISABLED notification, since only a
small number of places actually cared about the disctinction between 
EXTENSION_UNLOADED and EXTENSION_UNLOADED_DISABLED, and puts that information
into the details as well.

BUG=65510
TEST=Should be covered by existing unit & browser tests.


Review URL: http://codereview.chromium.org/5968009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70104 0039d316-1c4b-4281-b951-d872f2087c98

Fixing remoting_unittests crash on XP.
TBR=sergeyu

BUG=67928
TEST=None

Review URL: http://codereview.chromium.org/5963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70103 0039d316-1c4b-4281-b951-d872f2087c98

This regressed when I moved CrApplication out of base.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6065007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70102 0039d316-1c4b-4281-b951-d872f2087c98

And fix callers.

BUG=23581
TEST=trybots

Review URL: http://codereview.chromium.org/5848005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/6018008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70097 0039d316-1c4b-4281-b951-d872f2087c98

Since DownloadItem is now created before we analyze the file to determine its characteristics and final name/location, I have added a function SetFileCheckResults() to update DownloadItem after this process has been done.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5738007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70096 0039d316-1c4b-4281-b951-d872f2087c98

to pick up suppressions for fast/canvas/webgl/canvas-test.html and
fast/canvas/webgl/gl-pixelstorei.html unexpectedly crashing on
Windows.

BUG=none
TEST=none
TBR=andreip

Review URL: http://codereview.chromium.org/6075007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67303
TEST=media_unittests

Review URL: http://codereview.chromium.org/6046006

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/5970011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70092 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67932

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70090 0039d316-1c4b-4281-b951-d872f2087c98

Reverting the revert of named interface CL. Followup CL which addresses Pawel's comments is up at
http://codereview.chromium.org/5967003/

http://src.chromium.org/viewvc/chrome?view=rev&revision=67300

The change has been approved conditionally,
i.e. if the outstanding review comments are handled
in a follow-up as the top priority.

Two weeks have passed, and I have not seen the follow-up.
It is risky to keep this change in the tree, as it is already
non-trivial to revert.

Conflicts:

  chrome/browser/automation/automation_provider.cc
  chrome/test/ui/named_interface_uitest.cc
  ipc/ipc_channel_posix.cc

TBR=nirnimesh

BUG=chromium-os:8512
TEST=none

Review URL: http://codereview.chromium.org/5707006

TBR=phajdan.jr@chromium.org

BUG=chromium-os:8512
TEST=ui_tests --gtest_filter=NamedInterfaceTest.FLAKY_BasicNamedInterface

Review URL: http://codereview.chromium.org/6012006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70089 0039d316-1c4b-4281-b951-d872f2087c98

Principally to pick up fixed box-shadow.html suppression. Again
unfortunately more changes than just this being picked up.

BUG=none
TEST=none
TBR=andreip

Review URL: http://codereview.chromium.org/6031006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67933
TEST=none
TBR=garykac


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=works as before

Review URL: http://codereview.chromium.org/6048010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70084 0039d316-1c4b-4281-b951-d872f2087c98

The installer can now be run in a way that installs both Chrome and Chrome Frame
at the same time, into a shared directory.  The command line to do this is:

mini_installer.exe --multi-install --chrome --chrome-frame --ready-mode
--system-level --verbose-logging

This installs both products although only Chrome will have an entry in the
add/remove programs dialog that serves as an uninstallation command for both
products.  Chrome Frame will be installed in ready-mode, which means that the
user will have to opt-in or opt-out of using it.  The installer will create a
REG_DWORD value to indicate this mode, here:


HKEY_LOCAL_MACHINE\SOFTWARE\Google\Update\ClientState\{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}
 Value name: ChromeFrameReadyMode
 Value: 1

If the user opts-in to use GCF, setup will be run again to remove this value,
update Chrome's uninstallation commands to only uninstall Chrome, and add an
entry to the Add/Remove Programs dialog for GCF.  To do this, the installer
needs to be run with this switch:

 --multi-install --chrome-frame --system-level --ready-mode-opt-in --verbose-logging

If the user opts-out, Chrome Frame will be uninstalled by running the installer
with these arguments:

 --uninstall --chrome-frame --ready-mode --system-level --multi-install --verbose-logging

In addition to uninstalling GCF, this updates Chrome's uninstallation commands
accordingly and sets the ChromeFrameReadyMode value to 0 to avoid enabling ready
mode again.

Requirements that must currently be met in order to install Chrome and Chrome
Frame into the same shared location:
- Chrome Frame must not already be installed
OR
- Chrome Frame must be already installed as multi, into the shared location

**** other changes ****

The installer does no use the ap value for detecting other multi-install
products anymore.  Instead we inspect the uninstallation switches to see if
--multi-install is present.  Updated unit tests accordingly.

When uninstalling Chrome Frame along with Chrome, the Chrome Frame
uninstallation prompt is not shown.

Added safeguards:
If we attempt to install Chrome Frame multi over a single, install aborts and returns an error.
If we attempt to install Chrome Frame single over a multi, install aborts and returns an error.

TEST=See description above.
BUG=61609

Review URL: http://codereview.chromium.org/5989007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70083 0039d316-1c4b-4281-b951-d872f2087c98

Renamed RemotingDirectoryService to DirectoryAddRequest. It will be used in RemotingSetupFlow to register host. Also added unittests for this code.

BUG=67218
TEST=Unittests

Review URL: http://codereview.chromium.org/6036001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70082 0039d316-1c4b-4281-b951-d872f2087c98

host state.

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/5955001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70081 0039d316-1c4b-4281-b951-d872f2087c98

Principally to pick up fixes to test_expectations.txt for two failures
from last roll:
 - Syntax error in fast/css/box-shadow.html suppression
 - Add TIMEOUT for fast/events/touch/touch-target.html

Unfortunately this picks up some other moderately large changes as well.

BUG=none
TEST=none
TBR=andreip

Review URL: http://codereview.chromium.org/6030009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67303
TEST=media_unittests

Review URL: http://codereview.chromium.org/6046006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70077 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kbr

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70076 0039d316-1c4b-4281-b951-d872f2087c98

Transmit the server certificate to the client via content description. This
allow secure encryption between Chromoting host and client.

BUG=None
TEST=remoting_unittests

Review URL: http://codereview.chromium.org/5804001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70075 0039d316-1c4b-4281-b951-d872f2087c98

Wrap the existing StreamSocketAdpaters in JingleSession with an extra of
SSLClientSocket and SSLServerSocket. Since the server certificate is
self-signed, SSLClientSocket will refuse to connect. An additional patch is
needed to transmit the certificate via other channels so client sSL socket can
accept this untrusted certificate.

BUG=None
TEST=remoting_unittests

Review URL: http://codereview.chromium.org/5675003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70074 0039d316-1c4b-4281-b951-d872f2087c98

This adds a test to make sure that we're getting the real effective and real user IDs in ProcessInfoSnapshot.

BUG=None
TEST=Ran the unit test and verified that it passed.

Review URL: http://codereview.chromium.org/5999007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67919
TEST=none
TBR=kbr

Review URL: http://codereview.chromium.org/6007004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=everything still works

Review URL: http://codereview.chromium.org/5968008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70071 0039d316-1c4b-4281-b951-d872f2087c98

This replaces a bunch of duplicated-per-library cros
function definitions and comments.

BUG=none
TEST=built it

Review URL: http://codereview.chromium.org/6086007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67918
TBR=hans

Review URL: http://codereview.chromium.org/5969008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70069 0039d316-1c4b-4281-b951-d872f2087c98

Have had some issues running this roll through the try servers. The
two outstanding failures on the canaries already have entries in
test_expectations.txt. Submitting to see whether the main builders
work.

TBR=andreip
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6047007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70068 0039d316-1c4b-4281-b951-d872f2087c98