- Dec 06, 2010
-
-
scherkus@chromium.org authored
Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363). One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TESt=none BUG=65404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68357 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 04, 2010
-
-
victorw@chromium.org authored
TBR=yutak BUG=65404 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68281 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68276 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 03, 2010
-
-
evan@chromium.org authored
BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5591004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68208 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Confusingly, we had a ToString() that returned a UTF-8 string and a ToStringVector() that returned wstrings. Since CppVariant is a small wrapper around NPVariant I made them both use UTF-8; it simplified most of the users anyway (which only dealt with ASCII anyway). BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5631002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68187 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
Also clean up downstream test expectations, they were added upstream http://trac.webkit.org/changeset/73212 TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68127 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/5619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=yutak TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68116 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 02, 2010
-
-
scherkus@chromium.org authored
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
-
antonm@chromium.org authored
It's been moved upstream with http://trac.webkit.org/changeset/73050 Review URL: http://codereview.chromium.org/5539004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68070 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2FW3C-SVG-1.1%2Fstruct-image-10-t.svg%20 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla%2Fbugs%2Fbug14929.html Fixed upstream here: http://trac.webkit.org/changeset/73089 BUG=64395,64394 TEST=webkit tests stay green Review URL: http://codereview.chromium.org/5539003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68048 0039d316-1c4b-4281-b951-d872f2087c98
-
jparent@chromium.org authored
It was moved upstream in r73093. TEST=none BUG=none Review URL: http://codereview.chromium.org/5557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68032 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
TBR=tony TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67980 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/5503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67934 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
to allow the dump including the heap memory. TEST=none BUG=none Review URL: http://codereview.chromium.org/5262011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67925 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
TBR=ojan Review URL: http://codereview.chromium.org/5534001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67915 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 01, 2010
-
-
thakis@chromium.org authored
gwtquake lets the renderer create > 300 threads (one per audio element?), and eventually thread creation fails. This CL makes the media code more robust against thread creation failure (currently, it just crashes the renderer). The Real Fix probably is to have a thread pool for media stuff instead of one thread per media object. And maybe threads just leak under some circumstances. I will file a follow-up bug for that case, hopefully with a reduced test case. BUG=53867,61293 TEST=Completing the first level in gwtquake shouldn't crash the renderer. Review URL: http://codereview.chromium.org/5362003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67824 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
Disable failing NaClUITest.SrpcBasicTest and add back in test expectation that was erroneously removed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67811 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67807 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 30, 2010
-
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalyr@chromium.org authored
BUG=none TEST=none TBR=ojan Review URL: http://codereview.chromium.org/5364008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67759 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
In the current code calling dispatcher->DidXxx in an operation's DidXxx method MAY indirectly delete the operation itself depending on the dispatcher's implementation. I was confused by this several times and I want to make this flow more explicit. This patch lets FileSystemOperation control its lifetime by itself so that each callback dispatcher implementation does not need to take care of it. Also moved BrowserFileSystemCallbackDispatcher into file_system_dispatcher_host.cc as it's only used in it and its implementation is tightly coupled with the DispatcherHost. BUG=60243 TEST=none Review URL: http://codereview.chromium.org/4821005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67732 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67685 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67684 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 29, 2010
-
-
tony@chromium.org authored
All dependencies were already removed. BUG=64260 Review URL: http://codereview.chromium.org/5318009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67586 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
I haven't deleted it yet because it might be useful for debugging failures. I'll delete it in a separate change so it's easy for someone to cherry pick the change back. BUG=64260 Review URL: http://codereview.chromium.org/5301003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67571 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
to mock menu item strings. This change was once reverted at r67248 due to hitting a webkit bug and is re-landing because the bug was fixed at http://trac.webkit.org/changeset/72721. BUG=63460 TEST=LayoutTest/editing/spelling/context-menu-suggestions.html Review URL: http://codereview.chromium.org/5120002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67505 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 28, 2010
-
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5298008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67497 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 25, 2010
-
-
loislo@chromium.org authored
TBR=jparent git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67425 0039d316-1c4b-4281-b951-d872f2087c98
-
loislo@chromium.org authored
Test is failing for unknown reason. Will investigate it a bit later. BUG_LOISLO WIN RELEASE : http/tests/appcache/online-whitelist.html = TEXT BUG=none TEST=none TBR= Review URL: http://codereview.chromium.org/5318005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67402 0039d316-1c4b-4281-b951-d872f2087c98
-
loislo@chromium.org authored
BUG64401 WIN : fast/filesystem/op-copy.html = TEXT BUG=none TEST=none TBR=vitalir Review URL: http://codereview.chromium.org/5261006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67397 0039d316-1c4b-4281-b951-d872f2087c98
-
jparent@chromium.org authored
Add a newly flaky test to test_expecations: fast/repaint/block-layout-inline-children-replaced.html. TEST=none BUG=none TBR=thakis,loislo Review URL: http://codereview.chromium.org/5287002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67389 0039d316-1c4b-4281-b951-d872f2087c98
-
jparent@chromium.org authored
to test_expectations due to image failures. TEST=none BUG=none TBR=thakis,loislo Review URL: http://codereview.chromium.org/5260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67388 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
* webkit/glue/ - Add overloads of queryLocalizedString() functions They will be added to WebKit::WebKitClient later. - Add implementations for WebLocalizedString::Validation* - Add message strings The English strings are different from WebKit's to avoid the brusque WebKit's strings. Port some messages from Mozilla. * webkit/tools/test_shell/ and webkit/support/ Hook queryLocalizedString() functions in order to return messages same as WebKit in layout test. BUG=28264 TEST=LayoutTests/fast/forms/validationMessage.html Review URL: http://codereview.chromium.org/4678006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67382 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 24, 2010
-
-
tony@chromium.org authored
BUG=64260 Review URL: http://codereview.chromium.org/5334006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67321 0039d316-1c4b-4281-b951-d872f2087c98
-
loislo@chromium.org authored
BUG=none TEST=none TBR=jparent Review URL: http://codereview.chromium.org/5357004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67252 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
Revert 67248 - TestShell: Backported EventSender.contextClick() improvement to mock menu item strings. BUG=63460 TEST=LayoutTest/editing/spelling/context-menu-suggestions.html TBR=morrita@chromium.org Review URL: http://codereview.chromium.org/5120002 TBR=morrita@chromium.org Review URL: http://codereview.chromium.org/5363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67251 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
This is the chromium side of https://bugs.webkit.org/show_bug.cgi?id=49736. BUG=none TEST=webkit layout tests will be enabled after this CL. Review URL: http://codereview.chromium.org/5333001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67250 0039d316-1c4b-4281-b951-d872f2087c98
-