BUG=26509
TEST=none

Review URL: http://codereview.chromium.org/340072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31050 0039d316-1c4b-4281-b951-d872f2087c98

Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc.
Enable some tests meanwhile - now they should be stable enough.

BUG=18797,24664
TEST=ui_tests ok
Review URL: http://codereview.chromium.org/339009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98

Implement FormStructure and an initial method, EncodeUploadRequest.  This also adds SHA1HashString, a utility method to get the SHA-1 hash of an input string, with appropriate unit tests.

BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/355003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30980 0039d316-1c4b-4281-b951-d872f2087c98

Clean up the strings for sync code:
- Use FilePath for real file paths.
- Use std::string for PathString on Windows as well

TODO in a separate CL:
- Get rid of PathString typedef completely and directly use std::string everywhere.
- Use wchar_t in syncapi.h/.cc and get rid of sync_char16.

TEST=Existing tests are sufficient since this CL does a lot of code refactoring.
BUG=26342

Review URL: http://codereview.chromium.org/340055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30970 0039d316-1c4b-4281-b951-d872f2087c98

Too much cut'n'paste.  My eyes must have been closed when I screwed this up.

BUG=nope
TEST=read
Review URL: http://codereview.chromium.org/360008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30957 0039d316-1c4b-4281-b951-d872f2087c98

No more symbolic links in the .app.  Except for the ones that codesign adds.

The en_US.lproj directory should not exist, there should be only en.lproj.
Formerly, there was a symbolic link from en.lproj to en_US.lproj.

BUG=25578, 19165
TEST= - find C.app -name en_US.lproj should return nothing.
      - find C.app -name en.lproj should show en.lproj in C.app,
        C F.framework, and C H.app.
      - find C.app -type l should return nothing, however, on a signed build,
        it will still show symbolic links for CodeResources.
      - Say "What" again.  Say "What" again.  I dare you.  I double-dare you.
      - With English or U.S. English as the top or only choices in the
        International (10.5) or Language & Text (10.6) system preference
        pane's Language tab, the localized language should be English.
      - In this configuration, the Accept-Language header field should be
        "en-US,en;q=0.8".  See http://whatsmyuseragent.com/ and look for
        HTTP_ACCEPT_LANGUAGE.
Review URL: http://codereview.chromium.org/345057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30955 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't yet work in full-browser scenario, but allows me
to write a simple test.

TEST=Covered by browser_tests.
BUG=21541

Review URL: http://codereview.chromium.org/341050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30952 0039d316-1c4b-4281-b951-d872f2087c98

Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

Original review: http://codereview.chromium.org/262020
This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest.

TBR=agl

BUG=20012, 20714, 23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.

Review URL: http://codereview.chromium.org/361002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30948 0039d316-1c4b-4281-b951-d872f2087c98

Revert 30938 - Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

BUG=20012,20714,23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.
Review URL: http://codereview.chromium.org/262020
Review URL: http://codereview.chromium.org/359001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30939 0039d316-1c4b-4281-b951-d872f2087c98

Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.

While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.

BUG=20012,20714,23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.
Review URL: http://codereview.chromium.org/262020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30938 0039d316-1c4b-4281-b951-d872f2087c98

A lot of cruft and repeated code has deposited over the years on chrome's initialization code.
This CL makes it all much more clear and straightforward. There is no fundamental change of
behavior except the order of certain things is different but it should not alter the observed
operation.

- chrome's and chromium load is fundamentally the same but most of the code was repeated
- chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH
- Use of SearchPath() was dangerous and not needed
- removed google_update_client.cc and .h
- removed bunch of #ifdefs

TEST=all convered by UI tests already except [1]
BUG=none

[1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed').


Review URL: http://codereview.chromium.org/345036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98

Original review: http://codereview.chromium.org/340057

TBR=mpcomplete@chromium.org
BUG=22103
TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the
script should show up in the extension management UI. It should also work, though some scripts use
Firefox-specific APIs and those won't work in Chromium.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98

[Mac] Adds a new view that will allow us to animate the height property of views.  This class will be the base class for any view that needs to be animated.

BUG=None
TEST=No visible impact.  New unittests should pass.
Review URL: http://codereview.chromium.org/350002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30852 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/19282
TEST= Use report bug dialog on Mac OSX.
Review URL: http://codereview.chromium.org/340039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30815 0039d316-1c4b-4281-b951-d872f2087c98

document_idle."

Original code review: http://codereview.chromium.org/339064

BUG=26126
TBR=rafaelw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30796 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rafaelw@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30787 0039d316-1c4b-4281-b951-d872f2087c98

Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it".

Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first.

BUG=26126
TEST=Manual. Extensions with content scripts should work.

Review URL: http://codereview.chromium.org/339064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98

Handle GTK enter and leave notification events and pass them to WebKit as 
mouse move events. This prevents an HTML widget from staying in the mouseover 
state when the cursor leaves the window. Add a new ui test that checks 
the specific case that was broken by warping the mouse pointer inside and 
outside the content area. 

BUG=24660
TEST=ui_tests 

patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98

(in preparation for upstreaming the api)

Review URL: http://codereview.chromium.org/340049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30764 0039d316-1c4b-4281-b951-d872f2087c98

This gives us one less file to load on startup.  This does mean
that some tests need to explicitly include theme_resources.rc.

BUG=24035

Review URL: http://codereview.chromium.org/348033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/340045 for the original code.

This includes a newer version of GTM that solves the problem with nib loading on 10.6.

TEST=http://codereview.chromium.org/340045
BUG=none
Review URL: http://codereview.chromium.org/343082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30743 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/339079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30738 0039d316-1c4b-4281-b951-d872f2087c98

This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726

TBR=estade

Review URL: http://codereview.chromium.org/343080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98

mouse move events. This prevents an HTML widget from staying in the mouseover 
state when the cursor leaves the window. Add a new ui test that checks 
the specific case that was broken by warping the mouse pointer inside and 
outside the content area. 

BUG=24660
TEST=ui_tests 

patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show

Review URL: http://codereview.chromium.org/354010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9295,8077
TEST=trybots
Review URL: http://codereview.chromium.org/340052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30714 0039d316-1c4b-4281-b951-d872f2087c98

10.6 loads xibs differently, breaking GTMIBArray

TBR=mark@chromium.org
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30702 0039d316-1c4b-4281-b951-d872f2087c98

- These two pages should now auto size vertically the labels.
  - The label should be top aligned with controls in the group when the group is taller.
  - The content should be vertically centered when the label is taller.
- All the textfields should always be tall enough to show content.
- Radios/checkbox should word wrap to show all their text.
- The spacing between groups is a little more even
- DEPS roll to pick up newer GTM with GTMIBArray.
- A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc.
Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment).
Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up).

TEST=see cl description for what should be working now.
BUG=20538
Review URL: http://codereview.chromium.org/340045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30696 0039d316-1c4b-4281-b951-d872f2087c98

Add the ability for objects which derive from RefCountedThreadSafe to specify a destructor trait.  This allows browser objects to specify which thread they're terminated on.  The benefit is we avoid the need to do manual ref counting when an object posts tasks to itself on different threads, if an object must be destructed on a specific thread.

This patch adds initial support and only shows one example with ResourceMessageFilter.  I will do the rest in a follow-up patch to keep things small.

BUG=25354
TEST=added unit tests
Review URL: http://codereview.chromium.org/338065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30688 0039d316-1c4b-4281-b951-d872f2087c98

to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable.
The shell tries to treat it as a command expansion.  Use ${BUILT_PRODUCTS_DIR}
directly.

BUG=none
TEST=Nico
Review URL: http://codereview.chromium.org/353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30686 0039d316-1c4b-4281-b951-d872f2087c98

Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98

In theory this should result in a slightly faster app startup.

I will do a follow up change to merge it on Windows and get rid of
the code related to the extra file.

BUG=24035

Review URL: http://codereview.chromium.org/344038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98

of HtmlDialogView.

Added TODO to fix inaccurate font height metric for OS X font class (and maybe width).

Added the BrowserCommandExecutor protocol so that not just a
BrowserWindowController can be the window controller for a
ChromeEventProcessingWindow.

Added unittests.  Also tested manually with the bookmark sync setup
wizard dialog.

BUG=23073
TEST=added unittests, trybot, and manual testing

Review URL: http://codereview.chromium.org/344008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98

Added initial interface hooks betweek WebKit code and renderer-side worker code.
The proper messages are generated to fire off a shared worker, but they are currently
ignored by the browser process.

BUG=26233
TEST=none (will enable layout tests when basic functionality available)

Review URL: http://codereview.chromium.org/340036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30599 0039d316-1c4b-4281-b951-d872f2087c98

 * It simply says it's not supported as ChromeOS wont launch external program.
Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary.

BUG=23853
TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog.

Review URL: http://codereview.chromium.org/342040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30593 0039d316-1c4b-4281-b951-d872f2087c98

Implement the Extension History API, v 0.1.The first version is a weak wrapper around the HistoryServices object in Chrome.BUG=22952TEST=browser_tests.exe --gtest_filer=ExtensionApiTest.History
Review URL: http://codereview.chromium.org/313001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30561 0039d316-1c4b-4281-b951-d872f2087c98

Connect the various pieces for notifications... hook up NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/342043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30557 0039d316-1c4b-4281-b951-d872f2087c98

Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now.

BUG=23526
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload.

Review URL: http://codereview.chromium.org/327009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98