Commits · e99e4bf2b9aa13baae46f2a49ff9c9ed8ca631c7 · Pekka Paalanen / weston

Mar 17, 2016

clients & tests: Unify multiple definitions of x*alloc and related functions · e99e4bf2

Bryce Harrington authored 9 years ago and

Pekka Paalanen committed 9 years ago


Direct fail_on_null calls now produce output like:

    [weston-info] clients/weston-info.c:714: out of memory

xmalloc, et al produce output on failure like:

    [weston-info] out of memory (-1)

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

e99e4bf2

ivi-shell: simplify ivi_layout_screen_set_render_order · 4e221f03

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


It is not necessary check the ivi-id of pregiven objects (layer or
surface). Traversing the list of all objects is sure to find the exact
same pointer we start with, bugs aside.

The controller modules are responsible for providing valid pointers. We
cannot protect from invalid pointers anyway.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
[Pekka: fix subject, add commit message]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

4e221f03

ivi-shell: simplify ivi_layout_screen_add_layer · f46306f0

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


It is not necessary check the ivi-id of pregiven objects (layer or
surface). Traversing the list of all objects is sure to find the exact
same pointer we start with, bugs aside.

The controller modules are responsible for providing valid pointers. We
cannot protect from invalid pointers anyway.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
[Pekka: commit message]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

f46306f0

ivi-shell: simplify ivi_layout_set_render_order · 72ad164b

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


It is not necessary check the ivi-id of pregiven objects (layer or
surface). Traversing the list of all objects is sure to find the exact
same pointer we start with, bugs aside.

The controller modules are responsible for providing valid pointers. We
cannot protect from invalid pointers anyway.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
[Pekka: commit message]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

72ad164b

ivi-shell: simplify ivi_layout_layer_add_surface · 10942379

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


It is not necessary check the ivi-id of pregiven objects (layer or
surface). Traversing the list of all objects is sure to find the exact
same pointer we start with, bugs aside.

The controller modules are responsible for providing valid pointers. We
cannot protect from invalid pointers anyway.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
[Pekka: commit message]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

10942379

ivi-shell: simplify ivi_layout_remove_surface · 536d8335

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


It is not necessary check the ivi-id of pregiven objects (layer or
surface). Traversing the list of all objects is sure to find the exact
same pointer we start with, bugs aside.

The controller modules are responsible for providing valid pointers. We
cannot protect from invalid pointers anyway.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
[Pekka: commit message]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

536d8335

Mar 16, 2016

ivi-shell: remove add_configured_listener left-over · 5cbf1e81

Pekka Paalanen authored 9 years ago


In all my rebases, this got accidentally left behind. The implementation
was removed in 4a750397 but
32ca791d reintroduced it.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

5cbf1e81

ivi-shell: introduce ivi-layout-shell.h · 32ca791d

Pekka Paalanen authored 9 years ago


This new header encapsulates the API that ivi-layout offers to
ivi-shell.c to call.

ivi-shell.c no longer uses ivi-layout-private.h. This limits the
ivi-layout internal structures to just ivi-layout code.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>

32ca791d

ivi-shell: remove configured signal from ivi-layout · 4a750397

Pekka Paalanen authored 9 years ago


Now that ivi-layout calls directly into ivi-shell.c, this signal is no
longer used. Remove it.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>

4a750397

ivi-shell: call shell_surface_send_configure() directly · 1f821933

Pekka Paalanen authored 9 years ago


For some reason, it seems that ivi-layout.c has tried hard to avoid
calling directly into ivi-shell.c. This means there is a jump through
hoops just to get the configure event sent to the clients. Ivi-shell
registers a listener for a ivi-layout signal for sending the event.

Instead, let ivi-layout.c call directly into ivi-shell.c, and expose a
function to send out the configure events. This reduces some confusion
on who calls what.

The main idea though is that this makes ivi-shell.c not depend on struct
ivi_layout_surface fields directly anymore. In following patches,
ivi_layout_surface can be made opaque for ivi-shell.c.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>

1f821933

clients: fix incorrect format handling in simple-shm · 1ddb8dd8

Murray Calavera authored 9 years ago and

Pekka Paalanen committed 9 years ago


the `shm_format` function seems to assume the `wl_shm_format`
enum has bit-exclusive enumerations which is not true.

Signed-off-by: Murray Calavera <murray.calavera@gmail.com>
[Pekka: fix whitespace with an 'if'.]
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

1ddb8dd8

Mar 15, 2016

ivi-shell: add include guards on ivi-shell.h · f72df1df

Pekka Paalanen authored 9 years ago


It's our standard practice. This file will get used a bit more in the
future.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

f72df1df

ivi-shell: include config.h in ivi-layout-transition.c · ae8c3d87

Pekka Paalanen authored 9 years ago


Every .c file must include config.h as the first thing.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

ae8c3d87

simple-egl: use roundtrip after get_registry request · c21cb3d0

Marek Chalupa authored 9 years ago and

Pekka Paalanen committed 9 years ago


Sometimes weston-simple-egl aborts in create_surface
under some conditions. It is because wl_display_dispatch()
may not be enough to make sure we have all requried objects.
Can be modeled by wldbg:

  $ wldbg -i weston-simple-egl
  (wldbg) b re get_registry
  (wldbg) c
  (wldbg) c

After these steps the weston-simple-egl aborts, because
it has not got shell neither ivi-shell objects

Signed-off-by: Marek Chalupa <mchqwerty@gmail.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

c21cb3d0

ivi-shell: remove content_observer notification · 193e301c

Ucan, Emre (ADITG/SW1) authored 9 years ago and

Pekka Paalanen committed 9 years ago


The content observer notification struct and its
set API (ivi_layout_surface_set_content_observer)
are removed. Because they are unused.

Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

193e301c

ivi-shell: Remove all surface transitions when it is being removed. · dada6e3b

Mateusz Polrola authored 9 years ago and

Pekka Paalanen committed 9 years ago


If surface transitions are not removed when surface is being removed, it
can lead to crash later when transition will finish, as it will try to
reference already freed memory.
This change exposes function that can remove all existing transitions
for given surface and it is being called during surface cleanup.

Signed-off-by: Mateusz Polrola <mateuszx.potrola@intel.com>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

dada6e3b

Mar 10, 2016

desktop-shell: make panel clock configurable · c6a55dbf

Armin Krezović authored 9 years ago

This patch enhances the panel clock by adding a config file
option which can be used to either disable the clock or make
it also show seconds in the current clock format.

v2: Implement suggestions from Pekka:
    - Include Signed-off-by
    - Coding style fixes
    - Implement clock widget allocation by using
      width from cairo_text_extents
    - Highlight config option values in man page
v3: Implement suggestions from Pekka and Bryce:
    - Use CLOCK_FORMAT_* instead of FORMAT_* in the enum
    - Switch to using fixed clock widget size instead
      of one returned from cairo_text_extents
    - Fixes to config option highlighting in the man page
v4: Implement more suggestions from Pekka and Bryce:
    - Improve patch changelog
    - Move the check for CLOCK_FORMAT_NONE into the
      caller function
    - Fix a memory leak in panel_create introduced by
      previous revision of this patch

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57583


Signed-off-by: Armin Krezović <armin.krezovic@fet.ba>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>

c6a55dbf

clients: Use zalloc · 0d1a6223
Bryce Harrington authored 9 years ago
```
Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
```
0d1a6223

Mar 09, 2016

platform: explicitly cast the return value of weston_platform_get_egl_proc_address · cd9424ef

Matthias Treydte authored 9 years ago


This allows the header to be consumed by C++ compilers, because C++ does
away with C's implicit cast from (void*).
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

cd9424ef

option-parser: Handle short double-arg options · 38298ec0

Bryce Harrington authored 9 years ago


weston allows both short and long style options to take arguments.  In
the case of short options, allow an optional space between the option
name and value.  E.g., previously you could launch weston this way:

  weston -i2 -cmyconfig.ini

now you can also launch it like this:

  weston -i 2 -c myconfig.ini

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>

38298ec0

Mar 07, 2016

configure: Make jpeglib an optional dependency. · 66e16141

Emmanuel Gil Peyrot authored 9 years ago

It doesn’t make sense to fail the entire build when jpeglib isn’t
present, so this commit makes it optional just like libwebp in the
previous one, disabled with --without-jpeg and forced with --with-jpeg.

Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

66e16141

protocol: migrate to stable presentation-time.xml · b00c79b5

Pekka Paalanen authored 9 years ago


Remove the unstable presentation_timing.xml file, and use
presentation-time.xml from wayland-protocols instead to generate all the
Presentation extension bindings.

The following renames are done according to the XML changes:
- generated header includes
- enum constants and macros prefixed with WP_
- interface symbol names prefixed with wp_
- protocol API calls prefixed with wp_

Clients use wp_presentation_interface.name rather than hardcoding the
global interface name: presentation-shm, weston-info, presentation-test.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewed-by: Jonas Ådahl <jadahl@gmail.com>
[Pekka: updated wayland-protocols dependency to 1.2]

b00c79b5

Mar 04, 2016